update clustered indexes docs by CharLotteiu · Pull Request #5129 · pingcap/docs

CharLotteiu · 2021-03-26T07:06:14Z

What is changed, added or deleted? (Required)

Update the user documentation of clustered index feature introduced in v5.0-rc & v5.0.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: Update clustered-indexes.md docs-cn#5771, update the description related to clustered indexes docs-cn#5834, fix some wrong statements in clustered-indexes.md docs-cn#5864
Other reference link(s):
- clustered index project: https://github.com/pingcap/tidb/projects/45

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

CharLotteiu · 2021-03-26T07:07:08Z

/label need-cherry-pick-5.0
/label v5.0
/translation from-docs-cn
/status PTAL
/cc @tangenta @TomShawn

ti-chi-bot · 2021-03-26T07:07:10Z

@CharLotteiu: The label(s) need-cherry-pick-5.0 cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

Details

In response to this:

/label need-cherry-pick-5.0
/label v5.0
/translation from-docs-cn
/status PTAL
/cc @tangenta @TomShawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

CharLotteiu · 2021-03-26T07:07:22Z

/label needs-cherry-pick-5.0

TomShawn · 2021-03-26T12:15:13Z

/remove-status PTAL
/status require-change

ti-srebot · 2021-03-28T12:15:25Z

@CharLotteiu, please update your pull request.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: tangenta <tangenta@126.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2021-03-29T03:53:18Z

LGTM after addressing https://github.com/pingcap/docs/pull/5129/files#r602226514 and above comments.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2021-03-29T05:47:59Z

/lgtm

tangenta · 2021-03-29T07:45:55Z

Sorry, there is a patch PR for docs-cn pingcap/docs-cn#5864. Could you please also update those changes when it gets merged?

Co-authored-by: tangenta <tangenta@126.com>

tangenta · 2021-03-29T09:23:53Z

/lgtm

ti-chi-bot · 2021-03-29T09:23:55Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn
tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

TomShawn · 2021-03-29T11:14:23Z

/merge

ti-chi-bot · 2021-03-29T11:14:25Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 402511e

TomShawn · 2021-03-29T11:14:49Z

/remove-status require-change

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-29T11:15:56Z

cherry pick to release-5.0 in PR #5154

CharLotteiu added 2 commits March 25, 2021 14:29

contents from docs-cn pingcap#5771

c597e9c

contents from docs-cn pingcap#5834

f041c26

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2021

ti-chi-bot requested review from TomShawn and tangenta March 26, 2021 07:07

ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. v5.0 This PR/issue applies to TiDB v5.0. labels Mar 26, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 26, 2021

ti-chi-bot added the needs-cherry-pick-5.0 label Mar 26, 2021

fix dead link

ec637f9

tangenta reviewed Mar 26, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

Joyinqin mentioned this pull request Mar 26, 2021

add binlog usage restrictions #5125

Merged

11 tasks

fix grammar

ba5a45d

TomShawn reviewed Mar 26, 2021

View reviewed changes

ti-chi-bot added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Mar 26, 2021

tangenta reviewed Mar 27, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

tangenta reviewed Mar 27, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

tangenta reviewed Mar 27, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

Apply suggestions from code review

1197314

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: tangenta <tangenta@126.com>

CharLotteiu commented Mar 29, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

Apply suggestions from code review

70ded37

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

CharLotteiu commented Mar 29, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

Update clustered-indexes.md

6399077

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn reviewed Mar 29, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

TomShawn reviewed Mar 29, 2021

View reviewed changes

Comment thread system-variables.md Outdated

Apply suggestions from code review

daaa672

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021

contents from docs-cn pingcap#5864

ed20aba

tangenta reviewed Mar 29, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

Update clustered-indexes.md

6d8ac5b

Co-authored-by: tangenta <tangenta@126.com>

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2021

CharLotteiu commented Mar 29, 2021

View reviewed changes

Comment thread clustered-indexes.md

CharLotteiu added 2 commits March 29, 2021 18:07

Update clustered-indexes.md

6de802f

fix list format

402511e

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021

ti-chi-bot removed the status/require-change Needs the author to address comments. label Mar 29, 2021

ti-chi-bot merged commit 343e916 into pingcap:master Mar 29, 2021

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 29, 2021

cherry pick pingcap#5129 to release-5.0

23560f6

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 29, 2021

update clustered indexes docs (#5129) #5154

Merged

10 tasks

ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2021

update clustered indexes docs (#5129) (#5154)

a693f7e

TomShawn mentioned this pull request Apr 6, 2021

fix some wrong statements in clustered-indexes.md pingcap/docs-cn#5864

Merged

11 tasks

CharLotteiu deleted the clustered-index branch July 9, 2021 03:22

Conversation

CharLotteiu commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

CharLotteiu commented Mar 26, 2021

Uh oh!

ti-chi-bot commented Mar 26, 2021

Uh oh!

CharLotteiu commented Mar 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Mar 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-srebot commented Mar 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Mar 29, 2021

Uh oh!

TomShawn commented Mar 29, 2021

Uh oh!

tangenta commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tangenta commented Mar 29, 2021

Uh oh!

ti-chi-bot commented Mar 29, 2021

Uh oh!

Uh oh!

TomShawn commented Mar 29, 2021

Uh oh!

ti-chi-bot commented Mar 29, 2021

Uh oh!

TomShawn commented Mar 29, 2021

Uh oh!

ti-srebot commented Mar 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CharLotteiu commented Mar 26, 2021 •

edited

Loading

tangenta commented Mar 29, 2021 •

edited

Loading