update the description related to clustered indexes by tangenta · Pull Request #5834 · pingcap/docs-cn

tangenta · 2021-03-25T04:25:09Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: NA
Other reference link(s): Update clustered-indexes.md #5771 *: remove alter-primary-key configuration #5774

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

qiancai · 2021-03-25T05:48:11Z

/cc @coocood @lysu

TomShawn · 2021-03-25T06:38:29Z

/label needs-cherry-pick-5.0
/status PTAL
/translation doing
/assign @CharLotteiu
/label v5.0

lysu · 2021-03-25T10:35:19Z

/lgtm

ti-chi-bot · 2021-03-25T10:35:22Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

TomShawn · 2021-03-25T11:40:25Z

Rest /lgtm

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2021-03-26T03:37:13Z

/label require-LGT1

TomShawn · 2021-03-26T03:37:21Z

/merge

ti-chi-bot · 2021-03-26T03:37:24Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 07a26b6

TomShawn · 2021-03-26T03:38:49Z

 > **注意：**
 >
-> 该配置项不再生效。如果需要增删主键，请使用 `NONCLUSTERED` 代替。要了解关于 `CLUSTERED` 主键的详细信息，请参考[聚簇索引](/clustered-indexes.md)。
+> 该配置项已被废弃，目前仅在 `@@tidb_enable_clustered_index` 取值为 `INT_ONLY` 时生效。如果需要增删主键，请在建表时使用 `NONCLUSTERED` 关键字代替。要了解关于 `CLUSTERED` 主键的详细信息，请参考[聚簇索引](/clustered-indexes.md)。


This line has been translated by @Joyinqin in pingcap/docs#5105.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-26T03:39:58Z

cherry pick to release-5.0 in PR #5858

CharLotteiu · 2021-03-26T07:01:39Z

 | 功能 | 相关 issue | 解决方式 |
 |  ----  | ----  | ----- |
-| 聚簇索引 | [#565](https://github.com/pingcap/br/issues/565)       | 确保备份时 tidb_enable_clustered_index 变量和恢复时一致，否则会导致数据不一致的问题，例如 `default not found` 和数据索引不一致。 |
+| 聚簇索引 | [#565](https://github.com/pingcap/br/issues/565)       | 确保备份时 tidb_enable_clustered_index 全局变量和恢复时一致，否则会导致数据不一致的问题，例如 `default not found` 和数据索引不一致。 |


This line is assigned to @TomShawn to translate together with #5224.

TomShawn · 2021-04-06T07:49:23Z

/remove-translation doing
/translation done

update the decription related to clustered indexes

f3b74eb

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2021

ti-chi-bot requested review from coocood and lysu March 25, 2021 05:48

ti-chi-bot assigned CharLotteiu Mar 25, 2021

ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021

fix linter

8c37fcf

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021

lysu mentioned this pull request Mar 25, 2021

*: change @@tidb_enable_clustered_index to ON/OFF/INT_ONLY pingcap/tidb#23529

Merged

TomShawn reviewed Mar 25, 2021

View reviewed changes

Comment thread clustered-indexes.md Outdated

TomShawn reviewed Mar 25, 2021

View reviewed changes

Comment thread system-variables.md Outdated

tangenta and others added 2 commits March 26, 2021 10:58

Update clustered-indexes.md

f5783d7

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update system-variables.md

07a26b6

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 26, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021

TomShawn reviewed Mar 26, 2021

View reviewed changes

ti-chi-bot merged commit 9c7ddf0 into pingcap:master Mar 26, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 26, 2021

cherry pick pingcap#5834 to release-5.0

1d1778d

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 26, 2021

update the description related to clustered indexes (#5834) #5858

Merged

11 tasks

ti-chi-bot pushed a commit that referenced this pull request Mar 26, 2021

update the description related to clustered indexes (#5834) (#5858)

80380b0

Joyinqin mentioned this pull request Mar 26, 2021

*: remove alter-primary-key configuration pingcap/docs#5105

Merged

11 tasks

CharLotteiu reviewed Mar 26, 2021

View reviewed changes

CharLotteiu mentioned this pull request Mar 26, 2021

update clustered indexes docs pingcap/docs#5129

Merged

10 tasks

This was referenced Mar 26, 2021

*: change @@tidb_enable_clustered_index to ON/OFF/INT_ONLY (#23529) pingcap/tidb#23585

Merged

*: remove alter-primary-key configuration (#5105) pingcap/docs#5141

Merged

tangenta mentioned this pull request Mar 29, 2021

fix some wrong statements in clustered-indexes.md #5864

Merged

11 tasks

This was referenced Mar 29, 2021

fix some wrong statements in clustered-indexes.md (#5864) #5865

Merged

update clustered indexes docs (#5129) pingcap/docs#5154

Merged

ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 6, 2021

Conversation

tangenta commented Mar 25, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

qiancai commented Mar 25, 2021

Uh oh!

TomShawn commented Mar 25, 2021

Uh oh!

lysu commented Mar 25, 2021

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Mar 25, 2021

Uh oh!

TomShawn commented Mar 26, 2021

Uh oh!

TomShawn commented Mar 26, 2021

Uh oh!

ti-chi-bot commented Mar 26, 2021

Uh oh!

TomShawn Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Mar 26, 2021

Uh oh!

CharLotteiu Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn commented Apr 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants