Skip to content

*: remove alter-primary-key configuration (#5105)#5141

Merged
ti-chi-bot merged 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-248ceed9f499
Mar 29, 2021
Merged

*: remove alter-primary-key configuration (#5105)#5141
ti-chi-bot merged 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-248ceed9f499

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Mar 29, 2021

cherry-pick #5105 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/5141

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/5141:release-5.0-248ceed9f499

First-time contributors' checklist

What is changed, added or deleted? (Required)

The alter-primary-key config option is deprecated & removed in v5.0, this PR updates the related documentation.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. v5.0 This PR/issue applies to TiDB v5.0. labels Mar 29, 2021
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 29, 2021
@ti-srebot ti-srebot requested review from TomShawn and tangenta March 29, 2021 02:56
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 29, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@Joyinqin you're already a collaborator in bot's repo.

@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@TomShawn: /merge in this pull request requires 1 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a8acf60

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2021
@ti-chi-bot ti-chi-bot merged commit 1bffdfd into pingcap:release-5.0 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. v5.0 This PR/issue applies to TiDB v5.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants