*: remove alter-primary-key configuration by tangenta · Pull Request #5774 · pingcap/docs-cn

tangenta · 2021-03-18T13:41:38Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

The alter-primary-key config option is deprecated & removed in v5.0, this PR update the related documentation.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: NA
Other reference link(s):
- TiDB PR: *: deprecate alter-primary-key configuration tidb#23270
- Related Docs PR: Update clustered-indexes.md #5771

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

tangenta · 2021-03-18T14:01:58Z

@TomShawn This PR has the same precedence as #5771. PTAL

tangenta · 2021-03-18T14:02:10Z

/cc @coocood @lysu

TomShawn · 2021-03-19T03:27:44Z

/label needs-cherry-pick-5.0

TomShawn · 2021-03-19T03:28:44Z

/status PTAL
/label require-LGT1
/assign @Joyinqin
/label v5.0
/translation doing

lysu · 2021-03-19T03:29:52Z

/LGTM

ti-chi-bot · 2021-03-19T03:29:56Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

TomShawn · 2021-03-19T07:47:02Z

Rest LGTM

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2021-03-19T12:55:35Z

/status require-change

ti-srebot · 2021-03-21T12:45:51Z

@lysu, @coocood, PTAL.

tangenta · 2021-03-22T02:19:53Z

/remove-label require-change

ti-chi-bot · 2021-03-22T02:19:54Z

@tangenta: The label(s) require-change cannot be applied. These labels are supported: DNM until Ansible tag is ready, Hacktoberfest, contribution, first-time-contributor, follow-up, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, v6.0, version-specific-changes-required, website.

Details

In response to this:

/remove-label require-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-03-23T02:29:10Z

/remove-status require-change
/lgtm

TomShawn · 2021-03-23T02:29:34Z

/lgtm

TomShawn · 2021-03-23T02:31:51Z

@coocood PTAL whether this PR can be merged. Thanks!

coocood · 2021-03-23T02:39:07Z

/lgtm

ti-chi-bot · 2021-03-23T02:39:08Z

@coocood: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-03-23T02:58:48Z

/merge

ti-chi-bot · 2021-03-23T02:58:50Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 283fc95

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-23T03:00:12Z

cherry pick to release-5.0 in PR #5794

Joyinqin · 2021-03-25T07:32:27Z

/translation done

Joyinqin · 2021-03-25T07:32:47Z

/remove-translation doing

*: remove alter-primary-key configuration

56d8672

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021

ti-chi-bot requested review from coocood and lysu March 18, 2021 14:02

ti-chi-bot added the needs-cherry-pick-5.0 label Mar 19, 2021

ti-chi-bot assigned Joyinqin Mar 19, 2021

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2021

TomShawn reviewed Mar 19, 2021

View reviewed changes

Comment thread tidb-configuration-file.md Outdated

TomShawn reviewed Mar 19, 2021

View reviewed changes

Comment thread tidb-configuration-file.md Outdated

Update tidb-configuration-file.md

95586b4

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

ti-chi-bot added the status/require-change Needs the author to address comments. label Mar 19, 2021

address comment

283fc95

ti-chi-bot removed the status/require-change Needs the author to address comments. label Mar 23, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021

ti-chi-bot merged commit d47fa05 into pingcap:master Mar 23, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 23, 2021

cherry pick pingcap#5774 to release-5.0

91d52ce

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 23, 2021

*: remove alter-primary-key configuration (#5774) #5794

Merged

11 tasks

ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2021

*: remove alter-primary-key configuration (#5774) (#5794)

0934290

tangenta mentioned this pull request Mar 25, 2021

update the description related to clustered indexes #5834

Merged

11 tasks

Joyinqin mentioned this pull request Mar 25, 2021

*: remove alter-primary-key configuration pingcap/docs#5105

Merged

11 tasks

ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 25, 2021

ti-chi-bot removed the translation/doing This PR’s assignee is translating this PR. label Mar 25, 2021

This was referenced Mar 26, 2021

update the description related to clustered indexes (#5834) #5858

Merged

*: remove alter-primary-key configuration (#5105) pingcap/docs#5141

Merged

Conversation

tangenta commented Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

tangenta commented Mar 18, 2021

Uh oh!

tangenta commented Mar 18, 2021

Uh oh!

TomShawn commented Mar 19, 2021

Uh oh!

TomShawn commented Mar 19, 2021

Uh oh!

lysu commented Mar 19, 2021

Uh oh!

ti-chi-bot commented Mar 19, 2021

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Mar 19, 2021

Uh oh!

TomShawn commented Mar 19, 2021

Uh oh!

ti-srebot commented Mar 21, 2021

Uh oh!

tangenta commented Mar 22, 2021

Uh oh!

ti-chi-bot commented Mar 22, 2021

Uh oh!

TomShawn commented Mar 23, 2021

Uh oh!

TomShawn commented Mar 23, 2021

Uh oh!

TomShawn commented Mar 23, 2021

Uh oh!

coocood commented Mar 23, 2021

Uh oh!

ti-chi-bot commented Mar 23, 2021

Uh oh!

TomShawn commented Mar 23, 2021

Uh oh!

ti-chi-bot commented Mar 23, 2021

Uh oh!

ti-srebot commented Mar 23, 2021

Uh oh!

Joyinqin commented Mar 25, 2021

Uh oh!

Joyinqin commented Mar 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tangenta commented Mar 18, 2021 •

edited

Loading