Skip to content

add the rsa generating command in check-before-deployment.md#5200

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
TomShawn:ssh-keygen-trsa
Apr 6, 2021
Merged

add the rsa generating command in check-before-deployment.md#5200
ti-chi-bot merged 3 commits into
pingcap:masterfrom
TomShawn:ssh-keygen-trsa

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Apr 2, 2021

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 2, 2021

/cc @ran-huang
/translation from-docs-cn
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/status PTAL
/label require-LGT1

@ti-chi-bot ti-chi-bot requested a review from ran-huang April 2, 2021 11:52
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 2, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 2, 2021

/label v5.0

@ti-chi-bot ti-chi-bot added the v5.0 This PR/issue applies to TiDB v5.0. label Apr 2, 2021
ran-huang
ran-huang reviewed Apr 2, 2021
View reviewed changes
Comment thread check-before-deployment.md Outdated
@ran-huang
Copy link
Copy Markdown
Contributor

ran-huang commented Apr 6, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2021
TomShawn
TomShawn commented Apr 6, 2021
View reviewed changes
Comment thread check-before-deployment.md Outdated
@ti-chi-bot ti-chi-bot requested a review from King-Dylan April 6, 2021 05:08
@TomShawn TomShawn requested a review from ran-huang April 6, 2021 05:08
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Apr 6, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 57fda0a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2021
@ti-chi-bot ti-chi-bot merged commit 267c628 into pingcap:master Apr 6, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 6, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5200 to release-4.0
3099001 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 6, 2021
Merged
10 tasks
@TomShawn TomShawn deleted the ssh-keygen-trsa branch April 6, 2021 08:45
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 6, 2021

cherry pick to release-4.0 in PR #5215

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 6, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5200 to release-5.0
e78f1d8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 6, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 6, 2021

cherry pick to release-5.0 in PR #5216

ti-chi-bot pushed a commit that referenced this pull request Apr 6, 2021
@ti-srebot
add the rsa generating command in check-before-deployment.md (#5200) (#…
b9d06f2 
…5215)
ti-chi-bot pushed a commit that referenced this pull request Apr 6, 2021
@ti-srebot
add the rsa generating command in check-before-deployment.md (#5200) (#…
37b9d30 
…5216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@King-Dylan King-Dylan Awaiting requested review from King-Dylan

@ran-huang ran-huang Awaiting requested review from ran-huang

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ran-huang @ti-chi-bot @ti-srebot