Update check-before-deployment.md by xyqcmss · Pull Request #5823 · pingcap/docs-cn

xyqcmss · 2021-03-24T06:42:33Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

新建的tidb用户没有.ssh目录, 需要手动执行rsa密钥生成指令, 生成.ssh目录, 同时中控机也要部署TiDB组件时, 需要配置中控机本机互信:
ssh-keygen -t rsa

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

xyqcmss · 2021-03-24T06:51:36Z

\cc @TomShawn
辛苦您看一下，谢谢
这个Your tests failed on CircleCI是为什么？

ran-huang · 2021-03-24T10:31:54Z

/cc TomShawn

TomShawn · 2021-03-24T11:28:33Z

/cc @pepezzzz @King-Dylan
/label needs-cherry-pick-4.0
/label needs-cherry-pick-master
/translation doing
/assign

ti-chi-bot · 2021-03-24T11:28:36Z

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @pepezzzz @King-Dylan
/label needs-cherry-pick-4.0
/label needs-cherry-pick-master
/translation doing
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TomShawn · 2021-03-24T11:36:08Z

/status PTAL

TomShawn · 2021-03-24T11:38:12Z

\cc @TomShawn
辛苦您看一下，谢谢
这个Your tests failed on CircleCI是为什么？

Accept my comments and the CircleCI will pass.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

xyqcmss · 2021-03-24T12:19:53Z

\cc @TomShawn
Sorry, I clicked on both of them, and it doesn’t seem to solve the problem.You may need to solve it again, thank you

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

xyqcmss · 2021-03-25T02:48:06Z

\cc @TomShawn
Thank you very much

ti-chi-bot · 2021-03-25T09:17:58Z

@King-Dylan: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

ti-chi-bot · 2021-03-25T09:45:48Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

TomShawn · 2021-03-25T09:48:05Z

/lgtm

TomShawn · 2021-03-25T09:48:28Z

/merge

ti-chi-bot · 2021-03-25T09:48:29Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: c67cdef

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-25T09:49:58Z

cherry pick to release-4.0 in PR #5845

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-03-25T09:50:39Z

cherry pick to master in PR #5846

TomShawn · 2021-04-02T11:52:43Z

/translation done
/remove-translation doing

Update check-before-deployment.md

a7d58e2

ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 24, 2021

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2021

xyqcmss added 2 commits March 24, 2021 15:14

Update check-before-deployment.md

8730f9d

Update check-before-deployment.md

4f9d8db

ti-chi-bot requested a review from TomShawn March 24, 2021 10:31

TomShawn reviewed Mar 24, 2021

View reviewed changes

Comment thread check-before-deployment.md Outdated

TomShawn reviewed Mar 24, 2021

View reviewed changes

Comment thread check-before-deployment.md Outdated

ti-chi-bot assigned TomShawn Mar 24, 2021

ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-4.0 labels Mar 24, 2021

ti-chi-bot requested a review from King-Dylan March 24, 2021 11:28

ti-chi-bot added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Mar 24, 2021

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 24, 2021

ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Mar 24, 2021

xyqcmss and others added 2 commits March 24, 2021 20:13

Update check-before-deployment.md

52e1c9a

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update check-before-deployment.md

1136197

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn reviewed Mar 24, 2021

View reviewed changes

Comment thread check-before-deployment.md

Update check-before-deployment.md

a3b3e46

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

King-Dylan approved these changes Mar 25, 2021

View reviewed changes

TomShawn reviewed Mar 25, 2021

View reviewed changes

Comment thread check-before-deployment.md Outdated

Update check-before-deployment.md

c67cdef

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

yikeke approved these changes Mar 25, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 25, 2021

ti-chi-bot merged commit caf2391 into pingcap:release-5.0 Mar 25, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 25, 2021

cherry pick pingcap#5823 to release-4.0

5781dd6

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 25, 2021

Update check-before-deployment.md (#5823) #5845

Merged

11 tasks

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 25, 2021

cherry pick pingcap#5823 to master

0e85b16

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 25, 2021

Update check-before-deployment.md (#5823) #5846

Merged

11 tasks

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021

Update check-before-deployment.md (#5823) (#5845)

d32b763

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2021

Update check-before-deployment.md (#5823) (#5846)

5c40fbd

yikeke added the v5.0 This PR/issue applies to TiDB v5.0 label Mar 31, 2021

TomShawn mentioned this pull request Apr 2, 2021

add the rsa generating command in check-before-deployment.md pingcap/docs#5200

Merged

10 tasks

ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 2, 2021

This was referenced Apr 6, 2021

add the rsa generating command in check-before-deployment.md (#5200) pingcap/docs#5215

Merged

add the rsa generating command in check-before-deployment.md (#5200) pingcap/docs#5216

Merged

Liuxiaozhen12 mentioned this pull request Jul 1, 2021

tidb-configuration-file: add graceful-wait-before-shutdown #6574

Merged

11 tasks

This was referenced Jul 5, 2021

tidb-configuration-file: add graceful-wait-before-shutdown (#6574) #6584

Merged

tidb-configuration-file: add graceful-wait-before-shutdown (#6574) #6585

Merged

Conversation

xyqcmss commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

xyqcmss commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ran-huang commented Mar 24, 2021

Uh oh!

Uh oh!

Uh oh!

TomShawn commented Mar 24, 2021

Uh oh!

ti-chi-bot commented Mar 24, 2021

Uh oh!

TomShawn commented Mar 24, 2021

Uh oh!

TomShawn commented Mar 24, 2021

Uh oh!

xyqcmss commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

xyqcmss commented Mar 25, 2021

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

TomShawn commented Mar 25, 2021

Uh oh!

TomShawn commented Mar 25, 2021

Uh oh!

ti-chi-bot commented Mar 25, 2021

Uh oh!

ti-srebot commented Mar 25, 2021

Uh oh!

ti-srebot commented Mar 25, 2021

Uh oh!

TomShawn commented Apr 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xyqcmss commented Mar 24, 2021 •

edited

Loading

xyqcmss commented Mar 24, 2021 •

edited

Loading

xyqcmss commented Mar 24, 2021 •

edited

Loading