Skip to content

tidb-configuration-file: add graceful-wait-before-shutdown#6574

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:graceful_shutdown
Jul 5, 2021
Merged

tidb-configuration-file: add graceful-wait-before-shutdown#6574
ti-chi-bot merged 2 commits into
pingcap:masterfrom
Liuxiaozhen12:graceful_shutdown

Conversation

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Jul 1, 2021

What is changed, added or deleted? (Required)

Closes: #5823

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Liuxiaozhen12
Copy link
Copy Markdown
Contributor Author

Liuxiaozhen12 commented Jul 1, 2021

/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-5.1
/translation from-docs

@Liuxiaozhen12 Liuxiaozhen12 added needs-cherry-pick-release-5.0 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jul 1, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 1, 2021 11:05
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2021
TomShawn
TomShawn reviewed Jul 5, 2021
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
Comment thread tidb-configuration-file.md Outdated
Comment thread tidb-configuration-file.md Outdated
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 5, 2021
@Liuxiaozhen12 @TomShawn
Apply suggestions from code review
5a8eb2f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Liuxiaozhen12 Liuxiaozhen12 requested a review from TomShawn July 5, 2021 03:03
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 5, 2021
TomShawn
TomShawn approved these changes Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 5, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jul 5, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5a8eb2f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ti-chi-bot ti-chi-bot merged commit 37f8046 into pingcap:master Jul 5, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6584.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jul 5, 2021

In response to a cherrypick label: new pull request created: #6585.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
tidb-configuration-file: add graceful-wait-before-shutdown (#6574) (#…
f76a466 
…6584)
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
tidb-configuration-file: add graceful-wait-before-shutdown (#6574) (#…
33b4df7 
…6585)
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@Liuxiaozhen12 @3AceShowHand
tidb-configuration-file: add graceful-wait-before-shutdown (pingcap#6574
d661018 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Liuxiaozhen12 @ti-chi-bot @TomShawn