Skip to content

tidb-configuration-file: add graceful-wait-before-shutdown#5825

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
dveeden:graceful_shutdown
Jun 24, 2021
Merged

tidb-configuration-file: add graceful-wait-before-shutdown#5825
ti-chi-bot merged 1 commit into
pingcap:masterfrom
dveeden:graceful_shutdown

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Jun 22, 2021

Closes: #5823

What is changed, added or deleted? (Required)

tidb-configuration-file: add graceful-wait-before-shutdown

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 22, 2021 10:48
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2021
@TomShawn TomShawn requested review from bb7133 and zz-jason June 22, 2021 10:54
@TomShawn TomShawn added needs-cherry-pick-release-5.0 translation/doing This PR's assignee is translating this PR. labels Jun 22, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 22, 2021
@morgo morgo self-requested a review June 22, 2021 13:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 22, 2021

@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Jun 22, 2021

I'm not a reviewer, PTAL @TomShawn

@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Jun 22, 2021

/uncc bb7133

@dveeden dveeden force-pushed the graceful_shutdown branch from 610155e to 8dccf68 Compare June 23, 2021 05:27
dveeden
dveeden commented Jun 23, 2021
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
TomShawn
TomShawn reviewed Jun 23, 2021
View reviewed changes
Comment thread tidb-configuration-file.md Outdated
@dveeden @TomShawn
tidb-configuration-file: add graceful-wait-before-shutdown
d4a9cee 
Closes: pingcap#5823

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@dveeden dveeden force-pushed the graceful_shutdown branch from bff105a to d4a9cee Compare June 23, 2021 07:33
TomShawn
TomShawn approved these changes Jun 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d4a9cee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@ti-chi-bot ti-chi-bot merged commit 3e2a3c2 into pingcap:master Jun 24, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Jun 24, 2021 •
edited
Loading

I'm not a reviewer, PTAL @TomShawn

In fact you are a reviewer no matter whether the ti-chi-bot counts you or not.😂

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

In response to a cherrypick label: new pull request created: #5835.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
7 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 24, 2021

In response to a cherrypick label: new pull request created: #5836.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
7 tasks
ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
tidb-configuration-file: add graceful-wait-before-shutdown (#5825) (#…
7c0bf06 
…5835)
ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
tidb-configuration-file: add graceful-wait-before-shutdown (#5825) (#…
a966936 
…5836)
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 1, 2021
Merged
11 tasks
@Liuxiaozhen12
Copy link
Copy Markdown
Contributor

Liuxiaozhen12 commented Jul 1, 2021

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 1, 2021
This was referenced Jul 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

+2 more reviewers

@morgo morgo morgo approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

graceful-wait-before-shutdown is missing from documentation

6 participants

@dveeden @ti-chi-bot @bb7133 @TomShawn @Liuxiaozhen12 @morgo