Skip to content

dumpling-overview: Suggest 256 MB or less as file size#5328

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
dveeden:dumpling_max_file_size
Apr 16, 2021
Merged

dumpling-overview: Suggest 256 MB or less as file size#5328
ti-chi-bot merged 2 commits into
pingcap:masterfrom
dveeden:dumpling_max_file_size

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Apr 14, 2021

What is changed, added or deleted? (Required)

This is because lightning is suggesting this
for non-CSV files.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 16, 2021

/cc @lichunzhu
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation doing
/assign Joyinqin

@ti-chi-bot ti-chi-bot added the translation/doing This PR's assignee is translating this PR. label Apr 16, 2021
@ti-chi-bot ti-chi-bot requested a review from lichunzhu April 16, 2021 02:23
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 16, 2021
@lichunzhu
Copy link
Copy Markdown
Contributor

lichunzhu commented Apr 16, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
TomShawn
TomShawn reviewed Apr 16, 2021
View reviewed changes
Comment thread dumpling-overview.md Outdated
@dveeden @TomShawn
Update dumpling-overview.md
6f23528 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 16, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6f23528

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 900d553 into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@dveeden @ti-srebot
cherry pick pingcap#5328 to release-4.0
af18a3d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 16, 2021

cherry pick to release-4.0 in PR #5363

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@dveeden @ti-srebot
cherry pick pingcap#5328 to release-5.0
1419e3d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 16, 2021

cherry pick to release-5.0 in PR #5364

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
dumpling-overview: Suggest 256 MB or less as file size (#5328) (#5363)
0bc5278
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
dumpling-overview: Suggest 256 MB or less as file size (#5328) (#5364)
2256e0f
@Joyinqin Joyinqin mentioned this pull request Apr 19, 2021
Merged
11 tasks
@Joyinqin
Copy link
Copy Markdown
Contributor

Joyinqin commented Apr 19, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 19, 2021
This was referenced Apr 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dveeden @TomShawn @lichunzhu @ti-chi-bot @ti-srebot @Joyinqin