dumpling-overview: Suggest 256 MB or less as file size by Joyinqin · Pull Request #6053 · pingcap/docs-cn

Joyinqin · 2021-04-19T03:20:36Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

This is because lightning is suggesting this for non-CSV files.

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from: dumpling-overview: Suggest 256 MB or less as file size docs#5328
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Joyinqin · 2021-04-19T03:23:07Z

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs

Joyinqin · 2021-04-19T03:23:32Z

/cc @TomShawn @lichunzhu

TomShawn · 2021-04-19T11:31:24Z

 默认情况下，导出的文件会存储到 `./export-<current local time>` 目录下。常用选项如下：

- `-t` 用于指定导出的线程数。增加线程数会增加 Dumpling 并发度，但也会加大数据库内存消耗，因此不宜设置过大。
+- `-o` 用于选择存放导出文件的目录。


This is an outdated version. Please align the latest version of this doc: https://github.com/pingcap/docs/blob/master/dumpling-overview.md#improve-export-efficiency-through-concurrency

This reverts commit a18cd88.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

lichunzhu · 2021-04-25T03:05:15Z

To me -F isn't a concurrency option. Should we still put this line here or somewhere else?

TomShawn · 2021-04-25T03:28:19Z

To me -F isn't a concurrency option. Should we still put this line here or somewhere else?

This PR is translated from pingcap/docs#5328. If this is not the perfect place for -F, do you have any good idea where to put it?

lichunzhu · 2021-04-26T07:10:40Z

To me -F isn't a concurrency option. Should we still put this line here or somewhere else?

This PR is translated from pingcap/docs#5328. If this is not the perfect place for -F, do you have any good idea where to put it?

Put to here? Not so sure.

TomShawn · 2021-04-26T11:23:25Z

To me -F isn't a concurrency option. Should we still put this line here or somewhere else?

This PR is translated from pingcap/docs#5328. If this is not the perfect place for -F, do you have any good idea where to put it?

Put to here? Not so sure.

No problem.

TomShawn · 2021-04-26T11:24:47Z

 默认情况下，导出的文件会存储到 `./export-<current local time>` 目录下。常用选项如下：

 - `-t` 用于指定导出的线程数。增加线程数会增加 Dumpling 并发度，但也会加大数据库内存消耗，因此不宜设置过大。
+- `-F` 选项用于指定单个文件的最大大小（单位为 `MiB`，可接受类似 `5GiB` 或 `8KB` 的输入）。如果你想使用 TiDB Lightning 将该文件加载到 TiDB 实例中，建议将 `-F` 选项的值保持在 256 MiB 或以下。


@Joyinqin Please move this line to line 72 and also update the English version. Thanks!

Done in pingcap/docs#5521

TomShawn

/label-require LGT1

ti-chi-bot · 2021-04-27T02:25:56Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

TomShawn · 2021-04-27T02:26:44Z

/label require-LGT1

lichunzhu · 2021-04-28T03:27:16Z

/lgtm

TomShawn · 2021-04-28T03:29:13Z

/merge

ti-chi-bot · 2021-04-28T03:29:15Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 4948c9b

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-28T03:30:32Z

cherry pick to release-4.0 in PR #6187

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-28T03:31:47Z

cherry pick to release-5.0 in PR #6188

Update dumpling-overview.md

3609606

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2021

ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 19, 2021

ti-chi-bot requested review from TomShawn and lichunzhu April 19, 2021 03:23

TomShawn reviewed Apr 19, 2021

View reviewed changes

Joyinqin added 4 commits April 20, 2021 10:15

Merge remote-tracking branch 'upstream/master' into dumpling-patch

1483657

Update dumpling-overview.md

030ae76

Merge remote-tracking branch 'upstream/master' into dumpling-patch

158d961

Update grafana-tikv-dashboard.md

a18cd88

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2021

Revert "Update grafana-tikv-dashboard.md"

50664f9

This reverts commit a18cd88.

ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2021

TomShawn reviewed Apr 22, 2021

View reviewed changes

Comment thread dumpling-overview.md Outdated

Apply suggestions from code review

ba088bf

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn reviewed Apr 26, 2021

View reviewed changes

Joyinqin added 2 commits April 27, 2021 10:14

Merge remote-tracking branch 'upstream/master' into dumpling-patch

4069547

Update dumpling-overview.md

36d1f86

Update dumpling-overview.md

4948c9b

TomShawn approved these changes Apr 27, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021

ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 27, 2021

Joyinqin mentioned this pull request Apr 27, 2021

Move the part of parameter description in dumpling-overview.md pingcap/docs#5521

Merged

11 tasks

This was referenced Apr 28, 2021

Move the part of parameter description in dumpling-overview.md (#5521) pingcap/docs#5534

Merged

Move the part of parameter description in dumpling-overview.md (#5521) pingcap/docs#5535

Merged

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021

ti-chi-bot merged commit 738e95d into pingcap:master Apr 28, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 28, 2021

cherry pick pingcap#6053 to release-4.0

d2524ac

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 28, 2021

dumpling-overview: Suggest 256 MB or less as file size (#6053) #6187

Merged

11 tasks

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 28, 2021

cherry pick pingcap#6053 to release-5.0

5c5b105

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 28, 2021

dumpling-overview: Suggest 256 MB or less as file size (#6053) #6188

Merged

11 tasks

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021

dumpling-overview: Suggest 256 MB or less as file size (#6053) (#6188)

9d7a1d5

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021

dumpling-overview: Suggest 256 MB or less as file size (#6053) (#6187)

ec05095

Conversation

Joyinqin commented Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

Joyinqin commented Apr 19, 2021

Uh oh!

Joyinqin commented Apr 19, 2021

Uh oh!

TomShawn Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Joyinqin Apr 20, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lichunzhu commented Apr 25, 2021

Uh oh!

TomShawn commented Apr 25, 2021

Uh oh!

lichunzhu commented Apr 26, 2021

Uh oh!

TomShawn commented Apr 26, 2021

Uh oh!

TomShawn Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

Joyinqin Apr 27, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Apr 27, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Apr 27, 2021

Uh oh!

TomShawn commented Apr 27, 2021

Uh oh!

lichunzhu commented Apr 28, 2021

Uh oh!

TomShawn commented Apr 28, 2021

Uh oh!

ti-chi-bot commented Apr 28, 2021

Uh oh!

ti-srebot commented Apr 28, 2021

Uh oh!

ti-srebot commented Apr 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Joyinqin commented Apr 19, 2021 •

edited

Loading

TomShawn Apr 19, 2021 •

edited

Loading