Skip to content

Move the part of parameter description in dumpling-overview.md#5521

Merged
ti-chi-bot merged 3 commits into
pingcap:masterfrom
Joyinqin:move-patch
Apr 28, 2021
Merged

Move the part of parameter description in dumpling-overview.md#5521
ti-chi-bot merged 3 commits into
pingcap:masterfrom
Joyinqin:move-patch

Conversation

@Joyinqin
Copy link
Copy Markdown
Contributor

@Joyinqin Joyinqin commented Apr 27, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Move the part of parameter description in dumpling-overview.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 27, 2021 02:29
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2021
@Joyinqin
Copy link
Copy Markdown
Contributor Author

Joyinqin commented Apr 27, 2021

/translation no-need
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2021
TomShawn
TomShawn reviewed Apr 27, 2021
View reviewed changes
Comment thread dumpling-overview.md Outdated
TomShawn
TomShawn approved these changes Apr 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label require-LGT1

@Joyinqin Joyinqin mentioned this pull request Apr 27, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 27, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 27, 2021
@Joyinqin @TomShawn
Apply suggestions from code review
5fcab5a 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Apr 28, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 28, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5fcab5a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot merged commit 67d4dda into pingcap:master Apr 28, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 28, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5521 to release-4.0
b997050 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 28, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 28, 2021

cherry pick to release-4.0 in PR #5534

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 28, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5521 to release-5.0
0355fc2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 28, 2021
Merged
11 tasks
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Apr 28, 2021

cherry pick to release-5.0 in PR #5535

ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021
@ti-srebot
Move the part of parameter description in dumpling-overview.md (#5521) (
a493eb1 
#5534)
ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2021
@ti-srebot
Move the part of parameter description in dumpling-overview.md (#5521) (
113b0a8 
#5535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @ti-chi-bot @TomShawn @ti-srebot