Skip to content

correct a tikv config name#5401

Merged
ti-chi-bot merged 1 commit into
pingcap:release-5.0from
loosoo:patch-1
Apr 22, 2021
Merged

correct a tikv config name#5401
ti-chi-bot merged 1 commit into
pingcap:release-5.0from
loosoo:patch-1

Conversation

@loosoo
Copy link
Copy Markdown

@loosoo loosoo commented Apr 20, 2021

ttl-poll-check-interval -> ttl-check-poll-interval

First-time contributors' checklist

What is changed, added or deleted? (Required)

ttl-poll-check-interval -> ttl-check-poll-interval

mysql> show config;
| tikv | 10.186.1.1:20160 | storage.ttl-check-poll-interval | 12h

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

ttl-poll-check-interval -> ttl-check-poll-interval
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 20, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 20, 2021 03:36
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 20, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

Welcome @deanglc!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2021
@loosoo
Copy link
Copy Markdown
Author

loosoo commented Apr 20, 2021

/cc @CharLotteiu

@CharLotteiu
Copy link
Copy Markdown
Contributor

/label needs-cherry-pick-master
/translation doing
/assign

@ti-chi-bot ti-chi-bot added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 20, 2021
@ti-chi-bot ti-chi-bot requested review from sticnarf and removed request for 3pointer, CaitinChen and CharLotteiu April 20, 2021 03:48
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 and removed translation/doing This PR's assignee is translating this PR. labels Apr 20, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@TomShawn: These labels are not set on the issue: translation/doing.

Details

In response to this:

/remove-translation doing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Copy Markdown
Contributor

/retitle correct a tikv config name
/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot changed the title Update tikv-configuration-file.md correct a tikv config name Apr 22, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8577838

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit c940d05 into pingcap:release-5.0 Apr 22, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-4.0 in PR #5429

@TomShawn
Copy link
Copy Markdown
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to master in PR #5430

ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants