Skip to content

correct a tikv config name (#5401)#5429

Closed
ti-srebot wants to merge 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-c940d05d20d7
Closed

correct a tikv config name (#5401)#5429
ti-srebot wants to merge 1 commit into
pingcap:release-4.0from
ti-srebot:release-4.0-c940d05d20d7

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Apr 22, 2021

cherry-pick #5401 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/5429

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/5429:release-4.0-c940d05d20d7

ttl-poll-check-interval -> ttl-check-poll-interval

First-time contributors' checklist

What is changed, added or deleted? (Required)

ttl-poll-check-interval -> ttl-check-poll-interval

mysql> show config;
| tikv | 10.186.1.1:20160 | storage.ttl-check-poll-interval | 12h

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
7 tasks
@ti-srebot ti-srebot added contribution This PR is from a community contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Apr 22, 2021
@ti-srebot ti-srebot requested review from TomShawn and sticnarf April 22, 2021 03:12
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@deanglc please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs/invitations

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/close

@ti-chi-bot
Copy link
Copy Markdown
Member

@TomShawn: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants