Skip to content

*: update add columns features#6677

Merged
ti-chi-bot merged 1 commit into
pingcap:masterfrom
zimulala:zimuxia/update-add-cols
Nov 1, 2021
Merged

*: update add columns features#6677
ti-chi-bot merged 1 commit into
pingcap:masterfrom
zimulala:zimuxia/update-add-cols

Conversation

@zimulala
Copy link
Copy Markdown
Contributor

@zimulala zimulala commented Oct 29, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

There is no series of GA tests for add columns. I think it is better to update the document.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn October 29, 2021 08:00
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2021
@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.0 translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 29, 2021
@morgo morgo self-requested a review October 29, 2021 19:25
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2021
@zimulala
Copy link
Copy Markdown
Contributor Author

zimulala commented Nov 1, 2021

PTAL @TomShawn

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2021
@TomShawn TomShawn self-assigned this Nov 1, 2021
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. type/bugfix This PR fixes a bug. labels Nov 1, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn November 1, 2021 06:12
@TomShawn
Copy link
Copy Markdown
Contributor

TomShawn commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1bb0273

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@ti-chi-bot ti-chi-bot merged commit 516abd5 into pingcap:master Nov 1, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6697.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6698.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #6699.

@zimulala zimulala deleted the zimuxia/update-add-cols branch November 1, 2021 06:20
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants