Skip to content

basic features: add feature matrix#7365

Merged
TomShawn merged 11 commits into
pingcap:masterfrom
TomShawn:basic-features-zh
Nov 9, 2021
Merged

basic features: add feature matrix#7365
TomShawn merged 11 commits into
pingcap:masterfrom
TomShawn:basic-features-zh

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Nov 1, 2021

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Nov 1, 2021
@TomShawn TomShawn requested review from bb7133 and qiancai November 1, 2021 05:20
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2021
@TomShawn TomShawn added area/general Relates to TiDB overview, architecture, and other general descriptions. needs-cherry-pick-release-5.0 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Nov 1, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 1, 2021
Comment thread basic-features.md Outdated
| [`AUTO_INCREMENT` 列](/auto-increment.md) | Y | Y | Y | Y |
| [`AUTO_RANDOM` 列](/auto-random.md) | Y | Y | Y | Y |
| [DDL 算法断言](/sql-statements/sql-statement-alter-table.md) | Y | Y | Y | Y |
| Multi schema change: add column(s) | Y | Y | Y | N |
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bb7133 看不太懂这个功能,能稍加解释下吗?"多表结构变更"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update this record?pingcap/docs#6677

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread basic-features.md
| [`SHOW CONFIG`](/sql-statements/sql-statement-show-config.md) | 实验功能 | 实验功能 | 实验功能 | 实验功能 |
| [`SET CONFIG`](/dynamic-config.md) | 实验功能 | 实验功能 | 实验功能 | 实验功能 |

[^1]: TiDB 误将 latin1 处理为 utf8 的子集。见 [TiDB #18955](https://github.com/pingcap/tidb/issues/18955)。
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bb7133 我看这个 issue 已经 closed 了,这里是不是可以删掉这个注释呢?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不...这个是一直没有解决的问题,需要注明

Comment thread basic-features.md

[^1]: TiDB 误将 latin1 处理为 utf8 的子集。见 [TiDB #18955](https://github.com/pingcap/tidb/issues/18955)。

[^2]: TiDB 支持的完整 SQL 列表,见[语句参考](/sql-statements/sql-statement-select.md)。
Copy link
Copy Markdown
Contributor Author

@TomShawn TomShawn Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

语句参考 只列了 SELECT 相关的语法支持,并不是完整的 SQL 列表,是否也可以删掉这条注释呢?
@bb7133

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我建议保留,看了一下 "语句参考" 只列了 SELECT 的原因,是 "SQL Statement' 那个目录是没有链接的 -__-

Comment thread basic-features.md Outdated
Comment thread basic-features.md Outdated
Comment thread basic-features.md Outdated
| [数值类型](/data-type-numeric.md) | Y | Y | Y | Y |
| [日期和时间类型](/data-type-date-and-time.md) | Y | Y | Y | Y |
| [字符串类型](/data-type-string.md) | Y | Y | Y | Y |
| [JSON 类型](/data-type-json.md) | 实验功能 | 实验功能 | 实验功能 | 实验功能 |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为了和大部分其他文档保持一致,“实验功能” 是否都可以修改为 “实验特性”

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread basic-features.md
Comment thread basic-features.md Outdated
| [`AUTO_INCREMENT` 列](/auto-increment.md) | Y | Y | Y | Y |
| [`AUTO_RANDOM` 列](/auto-random.md) | Y | Y | Y | Y |
| [DDL 算法断言](/sql-statements/sql-statement-alter-table.md) | Y | Y | Y | Y |
| Multi schema change: add column(s) | 实验特性 | 实验特性 | 实验特性 | 实验特性 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn
是指一条语句中同时添加多个列的 DDL 操作。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~已修改

@TomShawn TomShawn requested review from qiancai and zimulala November 1, 2021 06:11
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
Comment thread basic-features.md
| [信息函数](/functions-and-operators/information-functions.md) | Y | Y | Y | Y |
| [JSON 函数](/functions-and-operators/json-functions.md) | 实验特性 | 实验特性 | 实验特性 | 实验特性 |
| [聚合函数](/functions-and-operators/aggregate-group-by-functions.md) | Y | Y | Y | Y |
| [窗口函数](/functions-and-operators/window-functions.md) | Y | Y | Y | Y |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个特性应该还没有 GA。

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [窗口函数](/functions-and-operators/window-functions.md) | Y | Y | Y | Y |
| [窗口函数](/functions-and-operators/window-functions.md) | Experimental | Experimental | Experimental | Experimental |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.pingcap.com/zh/tidb/dev/window-functions 这上面没有任何实验特性的说明。能否帮忙确认一下呢?谢谢

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是 GA 的 @zimulala @TomShawn

Comment thread basic-features.md Outdated
TomShawn and others added 2 commits November 8, 2021 15:41
Co-authored-by: Lynn <zimu_xia@126.com>
Co-authored-by: Lynn <zimu_xia@126.com>
@bb7133
Copy link
Copy Markdown
Member

bb7133 commented Nov 8, 2021

Rest LGTM

Comment thread basic-features.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Nov 9, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Nov 9, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 27d320e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2021
@TomShawn TomShawn merged commit 06e9bf1 into pingcap:master Nov 9, 2021
@TomShawn TomShawn deleted the basic-features-zh branch November 9, 2021 02:10
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #7436.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #7437.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #7438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/general Relates to TiDB overview, architecture, and other general descriptions. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants