Skip to content

Refine the layout of basic-features.md#6740

Merged
TomShawn merged 2 commits into
pingcap:masterfrom
TomShawn:modify-basic-feature-bug
Nov 9, 2021
Merged

Refine the layout of basic-features.md#6740
TomShawn merged 2 commits into
pingcap:masterfrom
TomShawn:modify-basic-feature-bug

Conversation

@TomShawn
Copy link
Copy Markdown
Contributor

@TomShawn TomShawn commented Nov 8, 2021

What is changed, added or deleted? (Required)

  • Refine the layout of basic-features.md
  • Correct the support status for TiDB Binlog

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn requested a review from qiancai November 8, 2021 02:41
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Nov 8, 2021
@TomShawn TomShawn requested a review from morgo November 8, 2021 02:41
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2021
@TomShawn TomShawn added needs-cherry-pick-release-5.0 type/bugfix This PR fixes a bug. translation/no-need No need to translate this PR. area/general Relates to TiDB overview, architecture, and other general descriptions. require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Nov 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Nov 8, 2021 •
edited
Loading

@morgo Could you confirm the following two items? Thanks!

  • This issue has been closed. Can we remove this annotation? [^1]: TiDB incorrectly treats latin1 as a subset of utf8. See [TiDB #18955](https://github.com/pingcap/tidb/issues/18955) for more details.
  • /sql-statements/sql-statement-select.md only lists the syntax supports related to SELECT, but it does not has a list of all SQL statement supported in TiDB. Can we remove this annotation? [^2]: See [Statement Reference](/sql-statements/sql-statement-select.md) for a full list of SQL statements supported.

morgo
morgo reviewed Nov 8, 2021
View reviewed changes
Comment thread basic-features.md Outdated
| `LOAD DATA INFILE` | Y | Y | Y | Y |
| `SELECT INTO OUTFILE` | Y | Y | Y | Y |
| `INNER JOIN`, `LEFT\|RIGHT [OUTER] JOIN` | Y | Y | Y | Y |
| `INNER JOIN`, `LEFT|RIGHT [OUTER] JOIN` | Y | Y | Y | Y |
Copy link
Copy Markdown
Contributor

@morgo morgo Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing display issues in GitHub markdown. Hopefully it is not an issue in the live markdown.

Copy link
Copy Markdown
Contributor Author

@TomShawn TomShawn Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I change it back.

TomShawn
TomShawn commented Nov 8, 2021
View reviewed changes
Comment thread basic-features.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor Author

TomShawn commented Nov 9, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 86d8a6f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2021
@TomShawn TomShawn merged commit 9cd842c into pingcap:master Nov 9, 2021
@TomShawn TomShawn deleted the modify-basic-feature-bug branch November 9, 2021 02:10
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 9, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6740
9f3b3aa 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 9, 2021

In response to a cherrypick label: new pull request created: #6762.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 9, 2021

In response to a cherrypick label: new pull request created: #6763.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 9, 2021

In response to a cherrypick label: new pull request created: #6764.

ti-chi-bot added a commit that referenced this pull request Nov 9, 2021
@ti-chi-bot
Refine the layout of basic-features.md (#6740) (#6764)
b49ff98
ti-chi-bot added a commit that referenced this pull request Nov 9, 2021
@ti-chi-bot
Refine the layout of basic-features.md (#6740) (#6762)
c029487
ti-chi-bot added a commit that referenced this pull request Nov 9, 2021
@ti-chi-bot
Refine the layout of basic-features.md (#6740) (#6763)
754627e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

+1 more reviewer

@morgo morgo morgo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/general Relates to TiDB overview, architecture, and other general descriptions. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ti-chi-bot @morgo @qiancai