Skip to content

parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG#394

Merged
foreyes merged 4 commits into
pingcap:masterfrom
foreyes:dev/add_agg_hint
Jul 23, 2019
Merged

parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG#394
foreyes merged 4 commits into
pingcap:masterfrom
foreyes:dev/add_agg_hint

Conversation

@foreyes
Copy link
Copy Markdown
Contributor

@foreyes foreyes commented Jul 22, 2019 •
edited
Loading

What problem does this PR solve?

Add new optimizer hints for TiDB PR: pingcap/tidb#11364

What is changed and how it works?

Change parser and a related Restore interface.

Check List

Tests

  • Unit test

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2019

Codecov Report

Merging #394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   70.16%   70.16%   +<.01%     
==========================================
  Files          32       32              
  Lines        7433     7434       +1     
==========================================
+ Hits         5215     5216       +1     
  Misses       1703     1703              
  Partials      515      515
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/misc.go 72.56% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837bc29...a836986. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2019 •
edited
Loading

Codecov Report

Merging #394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   70.16%   70.16%   +<.01%     
==========================================
  Files          32       32              
  Lines        7433     7434       +1     
==========================================
+ Hits         5215     5216       +1     
  Misses       1703     1703              
  Partials      515      515
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/misc.go 72.56% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837bc29...942fd00. Read the comment docs.

@foreyes foreyes changed the title [WIP] parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG Jul 22, 2019
kennytm
kennytm reviewed Jul 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread parser_test.go Outdated
@foreyes @kennytm
code clear
942fd00 
Co-Authored-By: kennytm <kennytm@gmail.com>
@foreyes
Copy link
Copy Markdown
Contributor Author

foreyes commented Jul 23, 2019

PTAL @crazycs520 @kennytm

@kennytm kennytm added the status/LGT1 LGT1 label Jul 23, 2019
@foreyes foreyes requested a review from alivxxx July 23, 2019 06:24
@foreyes
Copy link
Copy Markdown
Contributor Author

foreyes commented Jul 23, 2019

PTAL. @lamxTyler

alivxxx
alivxxx approved these changes Jul 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes merged commit 09602ee into pingcap:master Jul 23, 2019
@foreyes foreyes deleted the dev/add_agg_hint branch July 23, 2019 06:30
@foreyes foreyes mentioned this pull request Jul 24, 2019
Merged
foreyes added a commit to foreyes/parser that referenced this pull request Sep 16, 2019
@foreyes
parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG (pingc…
ae2bf8d 
…ap#394)
@foreyes foreyes mentioned this pull request Sep 16, 2019
Merged
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@foreyes
parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG (pingc…
c1d9625 
…ap#394)
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@foreyes
parser: add TableOptimizerHint TIDB_HASHAGG and TIDB_STREAMAGG (pingc…
3fe3175 
…ap#394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@crazycs520 crazycs520 Awaiting requested review from crazycs520

+1 more reviewer

@alivxxx alivxxx alivxxx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@foreyes @kennytm @alivxxx