Skip to content

cherry-pick sql hint related PRs into release-3.1#559

Merged
lzmhhh123 merged 9 commits into
pingcap:release-3.1from
foreyes:dev/cherry_pick_hint
Sep 17, 2019
Merged

cherry-pick sql hint related PRs into release-3.1#559
lzmhhh123 merged 9 commits into
pingcap:release-3.1from
foreyes:dev/cherry_pick_hint

Conversation

@foreyes
Copy link
Copy Markdown
Contributor

@foreyes foreyes commented Sep 16, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick sql hint related PRs into release-3.1:

#394 #424 #491 #513 #517 #446 #550

What is changed and how it works?

cherry-pick and resolve conflict.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@foreyes foreyes self-assigned this Sep 16, 2019
@foreyes foreyes changed the title Dev/cherry pick hint cherry-pick sql hint related PRs into release-3.1 Sep 16, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 16, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@2a177b2). Click here to learn what that means.
The diff coverage is 95.74%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.1     #559   +/-   ##
==============================================
  Coverage               ?   51.27%           
==============================================
  Files                  ?       31           
  Lines                  ?     6888           
  Branches               ?        0           
==============================================
  Hits                   ?     3532           
  Misses                 ?     3006           
  Partials               ?      350
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
misc.go 96.49% <100%> (ø)
ast/misc.go 21.18% <95.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a177b2...bf3dfbf. Read the comment docs.

@foreyes
Copy link
Copy Markdown
Contributor Author

foreyes commented Sep 16, 2019

PTAL. @lzmhhh123 @lamxTyler

alivxxx
alivxxx reviewed Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes added the status/LGT1 LGT1 label Sep 17, 2019
lzmhhh123
lzmhhh123 approved these changes Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 merged commit a90dba5 into pingcap:release-3.1 Sep 17, 2019
@foreyes foreyes deleted the dev/cherry_pick_hint branch September 17, 2019 05:12
eurekaka pushed a commit to eurekaka/parser that referenced this pull request Nov 18, 2019
@foreyes @eurekaka
cherry-pick sql hint related PRs into release-3.1 (pingcap#559)
a1c7ec8
@eurekaka eurekaka mentioned this pull request Nov 18, 2019
Merged
eurekaka added a commit that referenced this pull request Nov 18, 2019
@eurekaka
cherry-pick sql hint related PRs into release-3.1 (#559) (#643)
80a9970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@alivxxx alivxxx alivxxx left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@foreyes foreyes

Labels

status/LGT1 LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@foreyes @alivxxx @lzmhhh123