Skip to content

parser: add agg_to_cop hint#517

Merged
lzmhhh123 merged 3 commits into
pingcap:masterfrom
foreyes:dev/add_agg_to_cop_hint
Aug 23, 2019
Merged

parser: add agg_to_cop hint#517
lzmhhh123 merged 3 commits into
pingcap:masterfrom
foreyes:dev/add_agg_to_cop_hint

Conversation

@foreyes
Copy link
Copy Markdown
Contributor

@foreyes foreyes commented Aug 23, 2019

What problem does this PR solve?

Add sql hint for aggregation push to coprocessor.

What is changed and how it works?

Add new syntax and tests.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes requested a review from lzmhhh123 August 23, 2019 02:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2019

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   71.61%   71.61%           
=======================================
  Files          32       32           
  Lines        7736     7736           
=======================================
  Hits         5540     5540           
  Misses       1671     1671           
  Partials      525      525
Impacted Files Coverage Δ
misc.go 96.42% <ø> (ø) ⬆️
parser.go 70.58% <ø> (ø) ⬆️
ast/misc.go 74.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641eaa1...9485493. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2019

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   71.61%   71.61%           
=======================================
  Files          32       32           
  Lines        7736     7736           
=======================================
  Hits         5540     5540           
  Misses       1671     1671           
  Partials      525      525
Impacted Files Coverage Δ
misc.go 96.42% <ø> (ø) ⬆️
parser.go 70.58% <ø> (ø) ⬆️
ast/misc.go 74.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab86600...d21e0ea. Read the comment docs.

@foreyes foreyes added the status/LGT1 LGT1 label Aug 23, 2019
lzmhhh123
lzmhhh123 previously approved these changes Aug 23, 2019
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@foreyes foreyes force-pushed the dev/add_agg_to_cop_hint branch from 84a7d73 to d21e0ea Compare August 23, 2019 06:40
@lzmhhh123 lzmhhh123 merged commit 64bfe3e into pingcap:master Aug 23, 2019
foreyes added a commit to foreyes/parser that referenced this pull request Sep 16, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants