Skip to content

change memory quota hint argument#513

Merged
foreyes merged 3 commits into
pingcap:masterfrom
foreyes:dev/change_memory_quota_hint
Aug 23, 2019
Merged

change memory quota hint argument#513
foreyes merged 3 commits into
pingcap:masterfrom
foreyes:dev/change_memory_quota_hint

Conversation

@foreyes
Copy link
Copy Markdown
Contributor

@foreyes foreyes commented Aug 21, 2019

What problem does this PR solve?

Argument should be x MB or x GB.
Executor need memory quota as int64.
Makes it possible to use MEMORY_QUOTA(0 MB)

What is changed and how it works?

Change TableOptimizerHint struct and parser

Check List

Tests

  • Unit test

@foreyes foreyes force-pushed the dev/change_memory_quota_hint branch 6 times, most recently from 906303a to ed07841 Compare August 22, 2019 06:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 22, 2019

Codecov Report

Merging #513 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   71.61%   71.61%           
=======================================
  Files          32       32           
  Lines        7736     7736           
=======================================
  Hits         5540     5540           
  Misses       1671     1671           
  Partials      525      525
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
ast/misc.go 74.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb5a46...c4ce508. Read the comment docs.

@foreyes foreyes force-pushed the dev/change_memory_quota_hint branch from ed07841 to 964f0b4 Compare August 22, 2019 07:08
@foreyes foreyes requested review from alivxxx and lzmhhh123 August 23, 2019 02:54
Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes added the status/LGT1 LGT1 label Aug 23, 2019
Comment thread parser.y
Copy link
Copy Markdown
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@foreyes foreyes merged commit ab86600 into pingcap:master Aug 23, 2019
foreyes added a commit to foreyes/parser that referenced this pull request Sep 16, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants