Skip to content

*: make 'grant all privileges' work right#400

Merged
jackysp merged 9 commits into
pingcap:masterfrom
tiancaiamao:privilege-check
Jul 30, 2019
Merged

*: make 'grant all privileges' work right#400
jackysp merged 9 commits into
pingcap:masterfrom
tiancaiamao:privilege-check

Conversation

@tiancaiamao
Copy link
Copy Markdown
Collaborator

@tiancaiamao tiancaiamao commented Jul 25, 2019

What problem does this PR solve?

See pingcap/tidb#11449

What is changed and how it works?

Add those privileges

	CreateTMPTablePriv: "Create_tmp_table_priv",
	LockTablesPriv:     "Lock_tables_priv",
	CreateRoutinePriv:  "Create_routine_priv",
	AlterRoutinePriv:   "Alter_routine_priv",
	EventPriv:          "Event_priv",

Make Priv2UserCol, AllGlobalPrivs consistent and many other changes.

Check List

Tests

  • Unit test

Side effects

  • Breaking backward compatibility

@tiancaiamao tiancaiamao added the type/bug-fix fix bug label Jul 25, 2019
kennytm
kennytm reviewed Jul 25, 2019
View reviewed changes
Comment thread mysql/const_test.go

for _, v := range AllGlobalPrivs {
_, ok := Priv2UserCol[v]
c.Assert(ok, IsTrue)
Copy link
Copy Markdown
Contributor

@kennytm kennytm Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

c.Assert(Priv2UserCol, HasKey, v)

Copy link
Copy Markdown

@imtbkcat imtbkcat Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comment @tiancaiamao

@imtbkcat
Copy link
Copy Markdown

imtbkcat commented Jul 29, 2019

ping @tiancaiamao

jackysp
jackysp reviewed Jul 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imtbkcat
imtbkcat approved these changes Jul 30, 2019
View reviewed changes
Copy link
Copy Markdown

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit 5238015 into pingcap:master Jul 30, 2019
@jackysp jackysp mentioned this pull request Jul 30, 2019
Merged
@tiancaiamao tiancaiamao deleted the privilege-check branch July 31, 2019 05:25
@imtbkcat
Copy link
Copy Markdown

imtbkcat commented Jul 31, 2019

@tiancaiamao please cherry-pick this pr to release-2.1 branch.

@lysu lysu mentioned this pull request Dec 17, 2019
Merged
lysu added a commit that referenced this pull request Dec 17, 2019
@lysu
*: make 'grant all privileges' work right (#400) (#686)
701d0da
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tiancaiamao @jackysp
*: make 'grant all privileges' work right (pingcap#400)
4b44a76
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tiancaiamao @jackysp
*: make 'grant all privileges' work right (pingcap#400)
4512873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

@jackysp jackysp jackysp left review comments

+1 more reviewer

@imtbkcat imtbkcat imtbkcat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/bug-fix fix bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiancaiamao @imtbkcat @kennytm @jackysp