*: make 'grant all privileges' work right (#400)#686
Merged
Conversation
lysu
requested review from
imtbkcat and
tiancaiamao
and removed request for
imtbkcat
imtbkcat
reviewed
Dec 17, 2019
| } | ||
|
|
||
| // AllGlobalPrivs is all the privileges in global scope. | ||
| var AllGlobalPrivs = []PrivilegeType{SelectPriv, InsertPriv, UpdatePriv, DeletePriv, CreatePriv, DropPriv, ProcessPriv, GrantPriv, ReferencesPriv, AlterPriv, ShowDBPriv, SuperPriv, ExecutePriv, IndexPriv, CreateUserPriv, TriggerPriv, CreateViewPriv, ShowViewPriv, CreateRolePriv, DropRolePriv, CreateTMPTablePriv, LockTablesPriv, CreateRoutinePriv, AlterRoutinePriv, EventPriv} |
There was a problem hiding this comment.
GrantPriv has been removed from AllGlobalPrivs, see #665 for detail.
Codecov Report
@@ Coverage Diff @@
## release-3.0 #686 +/- ##
=============================================
Coverage ? 64.6%
=============================================
Files ? 31
Lines ? 10870
Branches ? 0
=============================================
Hits ? 7023
Misses ? 3438
Partials ? 409
Continue to review full report at Codecov.
|
Collaborator
Author
|
test tidb with pingcap/tidb#14092 |
tangenta
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #400 to 3.0 which block other cherry-picks
This change is