Skip to content

Fix compatibility for OnUpdate, OnDelete and other clauses (#331, #392, #393)#642

Merged
tangenta merged 4 commits into
pingcap:release-3.0from
tangenta:release-3.0-on-update
Nov 20, 2019
Merged

Fix compatibility for OnUpdate, OnDelete and other clauses (#331, #392, #393)#642
tangenta merged 4 commits into
pingcap:release-3.0from
tangenta:release-3.0-on-update

Conversation

@tangenta
Copy link
Copy Markdown
Contributor

@tangenta tangenta commented Nov 18, 2019

Cherry-pick #331, #392, #393.

Fix pingcap/tidb#13424.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@7c50186). Click here to learn what that means.
The diff coverage is 8.51%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.0     #642   +/-   ##
==============================================
  Coverage               ?   63.89%           
==============================================
  Files                  ?       31           
  Lines                  ?    10831           
  Branches               ?        0           
==============================================
  Hits                   ?     6920           
  Misses                 ?     3502           
  Partials               ?      409
Impacted Files Coverage Δ
parser.go 86.4% <ø> (ø)
misc.go 96.42% <ø> (ø)
yy_parser.go 83.33% <100%> (ø)
ast/ddl.go 43.15% <4.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c50186...432dae2. Read the comment docs.

Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 LGT1 label Nov 20, 2019
gleonid and others added 4 commits November 20, 2019 12:35
* issues 280: Support ON UPDATE ddl statements

* issue 280: add generated file
)

* fix

* fix check for ColumnOption

* add test for match

* use array
@tangenta tangenta force-pushed the release-3.0-on-update branch from a07492a to 432dae2 Compare November 20, 2019 04:42
@tangenta tangenta changed the title Fix compatibility for OnUpdate, OnDelete and other clauses (#331, #392, #393, #337) Fix compatibility for OnUpdate, OnDelete and other clauses (#331, #392, #393) Nov 20, 2019
Copy link
Copy Markdown
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants