Skip to content

Fix compatibility for OnUpdate, OnDelete and other clauses (#331, #392, #393) (#642)#647

Merged
eurekaka merged 1 commit into
pingcap:release-3.1.6from
eurekaka:release-3.1.6
Nov 21, 2019
Merged

Fix compatibility for OnUpdate, OnDelete and other clauses (#331, #392, #393) (#642)#647
eurekaka merged 1 commit into
pingcap:release-3.1.6from
eurekaka:release-3.1.6

Conversation

@eurekaka
Copy link
Copy Markdown
Contributor

cherry-pick #642 to 3.1.6, since 3.1.6 has just rebased release-3.0 which needs this parser change.

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Nov 20, 2019

We shouldn't have a release-3.1.6 branch, only release-3.1 or release-3.0 branch 🤔

@eurekaka
Copy link
Copy Markdown
Contributor Author

eurekaka commented Nov 20, 2019

release-3.1 would be deprecated soon, and release-3.1.6 is the replacement. @coocood please help explain the existence of release-3.1.6 here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1.6@80a9970). Click here to learn what that means.
The diff coverage is 8.51%.

Impacted file tree graph

@@               Coverage Diff                @@
##             release-3.1.6     #647   +/-   ##
================================================
  Coverage                 ?   64.21%           
================================================
  Files                    ?       31           
  Lines                    ?    10962           
  Branches                 ?        0           
================================================
  Hits                     ?     7039           
  Misses                   ?     3513           
  Partials                 ?      410
Impacted Files Coverage Δ
parser.go 86.45% <ø> (ø)
misc.go 96.49% <ø> (ø)
yy_parser.go 83.33% <100%> (ø)
ast/ddl.go 43.15% <4.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a9970...68d0ee9. Read the comment docs.

@eurekaka eurekaka requested review from coocood and tangenta November 20, 2019 08:52
@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Nov 20, 2019

release-3.1 would be deprecated soon, and release-3.1.6 is the replacement

Then the branch name makes no sense since the next versions are 3.0.6 and 3.1.0.

@coocood
Copy link
Copy Markdown
Member

coocood commented Nov 20, 2019

@kennytm release-3.1.6 would be renamed to release-3.1 later

Copy link
Copy Markdown
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka merged commit 8b5639e into pingcap:release-3.1.6 Nov 21, 2019
@eurekaka eurekaka deleted the release-3.1.6 branch November 21, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants