Skip to content

support require SAN clause (#877)#879

Merged
tiancaiamao merged 1 commit into
pingcap:release-4.0from
lysu:cp-san-40
Jun 3, 2020
Merged

support require SAN clause (#877)#879
tiancaiamao merged 1 commit into
pingcap:release-4.0from
lysu:cp-san-40

Conversation

@lysu
Copy link
Copy Markdown
Collaborator

@lysu lysu commented Jun 1, 2020

cherry-pick #877 to 4.0


This change is Reviewable

* Support `require SAN` clause

* address comments
@lysu lysu requested review from a team, jackysp and kennytm June 1, 2020 05:58
@ghost ghost removed their request for review June 1, 2020 05:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2020

Codecov Report

Merging #879 into release-4.0 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           release-4.0     #879   +/-   ##
============================================
  Coverage        78.34%   78.34%           
============================================
  Files               40       40           
  Lines            14760    14770   +10     
============================================
+ Hits             11563    11571    +8     
- Misses            2516     2517    +1     
- Partials           681      682    +1     

Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Jun 1, 2020
@jackysp
Copy link
Copy Markdown
Contributor

jackysp commented Jun 1, 2020

/merge

@sre-bot
Copy link
Copy Markdown

sre-bot commented Jun 1, 2020

/run-all-tests

@tiancaiamao tiancaiamao merged commit c4ecb45 into pingcap:release-4.0 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants