Skip to content

support require SAN clause#877

Merged
kennytm merged 2 commits into
pingcap:masterfrom
lysu:dev-require-san
Jun 1, 2020
Merged

support require SAN clause#877
kennytm merged 2 commits into
pingcap:masterfrom
lysu:dev-require-san

Conversation

@lysu
Copy link
Copy Markdown
Collaborator

@lysu lysu commented May 29, 2020

What problem does this PR solve?

ref pingcap/tidb#14759

What is changed and how it works?

support require SAN in create user, grant, and so on

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • n/a

Related changes

  • Need to cherry-pick to the release branch(maybe 3.1)

This change is Reviewable

@lysu lysu requested a review from a team May 29, 2020 12:57
@ghost ghost requested review from kennytm and removed request for a team May 29, 2020 12:57
@lysu lysu changed the title Support require SAN clause support require SAN clause May 29, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2020

Codecov Report

Merging #877 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   78.28%   78.29%   +0.01%     
==========================================
  Files          40       40              
  Lines       14693    14700       +7     
==========================================
+ Hits        11503    11510       +7     
  Misses       2507     2507              
  Partials      683      683              

Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label May 29, 2020
Comment thread misc.go Outdated
Comment thread parser.y Outdated
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@lysu lysu requested a review from kennytm June 1, 2020 03:16
@jackysp
Copy link
Copy Markdown
Contributor

jackysp commented Jun 1, 2020

PTAL @kennytm

Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kennytm
Copy link
Copy Markdown
Contributor

kennytm commented Jun 1, 2020

Repairing CLA

@kennytm kennytm closed this Jun 1, 2020
@kennytm kennytm reopened this Jun 1, 2020
@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jun 1, 2020
@kennytm kennytm merged commit 87d29a8 into pingcap:master Jun 1, 2020
@lysu lysu deleted the dev-require-san branch June 1, 2020 05:30
tiancaiamao pushed a commit that referenced this pull request Jun 3, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* Support `require SAN` clause

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants