Skip to content

privileges: support require SAN#17539

Merged
sre-bot merged 5 commits into
pingcap:masterfrom
lysu:dev-require-san
Jun 5, 2020
Merged

privileges: support require SAN#17539
sre-bot merged 5 commits into
pingcap:masterfrom
lysu:dev-require-san

Conversation

@lysu
Copy link
Copy Markdown
Contributor

@lysu lysu commented May 29, 2020

What problem does this PR solve?

Issue Number: close #14759

Problem Summary:

see more in issue link

What is changed and how it works?

What's Changed:

  • add require SAN clause to maintain addition priv info
  • check SAN in user's cert when priv is "require SAN"

Related changes

Check List

Tests

  • Unit test
  • Integration test(WIP)

Side effects

  • n/a

Release note

  • Support authentication based on TLS certificate SAN field

This change is Reviewable

@lysu lysu added status/WIP security Everything related with security labels May 29, 2020
@lysu lysu requested a review from a team as a code owner May 29, 2020 13:44
@ghost ghost requested review from wshwsh12 and removed request for a team May 29, 2020 13:44
@github-actions github-actions Bot added the sig/execution SIG execution label May 29, 2020
@lysu
Copy link
Copy Markdown
Contributor Author

lysu commented May 29, 2020

need merge pingcap/parser#877 first, and WIP on more test

@lysu lysu modified the milestones: v3.1.2, v4.0.1 Jun 1, 2020
@lysu
Copy link
Copy Markdown
Contributor Author

lysu commented Jun 1, 2020

/run-all-tests

1 similar comment
@lysu
Copy link
Copy Markdown
Contributor Author

lysu commented Jun 1, 2020

/run-all-tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2020

Codecov Report

Merging #17539 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17539   +/-   ##
===========================================
  Coverage   79.6119%   79.6119%           
===========================================
  Files           525        525           
  Lines        143623     143623           
===========================================
  Hits         114341     114341           
  Misses        20105      20105           
  Partials       9177       9177           

Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Copy Markdown
Contributor Author

lysu commented Jun 5, 2020

/merge

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 5, 2020

Sorry @lysu, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part

@lysu lysu removed the sig/execution SIG execution label Jun 5, 2020
@lysu
Copy link
Copy Markdown
Contributor Author

lysu commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 5, 2020

Your auto merge job has been accepted, waiting for:

  • 17635

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@github-actions github-actions Bot added the sig/execution SIG execution label Jun 5, 2020
@sre-bot sre-bot merged commit 9e16c59 into pingcap:master Jun 5, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 5, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Jun 5, 2020

cherry pick to release-4.0 in PR #17698

@lysu lysu modified the milestones: v4.0.1, v4.0.2 Jun 5, 2020
sre-bot added a commit that referenced this pull request Jun 5, 2020
* cherry pick #17539 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict

Co-authored-by: lysu <sulifx@gmail.com>
@lysu lysu deleted the dev-require-san branch July 8, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security Everything related with security sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support authentication based on TLS certificate SAN field(s)

4 participants