executor, privilege: fix some two bug of RBAC#11273
Merged
Merged
Conversation
added 2 commits
July 16, 2019 15:07
Codecov Report
@@ Coverage Diff @@
## master #11273 +/- ##
===========================================
Coverage 81.2607% 81.2607%
===========================================
Files 423 423
Lines 90233 90233
===========================================
Hits 73324 73324
Misses 11607 11607
Partials 5302 5302 |
Author
|
/run-all-tests tidb-test=pr/847 |
Author
|
/run-common-test tidb-test=pr/847 |
Author
|
/run-common-test |
Author
|
/run-all-tests |
Contributor
|
LGTM |
Contributor
|
cherry pick to release-3.0 in PR #11356 |
zz-jason
pushed a commit
that referenced
this pull request
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix two bug of RBAC.
bug 1:
CURRENT_ROLEis not handle correctly inGRANT ROLEbug 2:
REVOKE ROLEdoesn't delete information inmysql.default_roleWhat is changed and how it works?
CURRENT_USERinGrantRoleExec, ifUserisCURRENT_USER, it will be set to current user.mysql.default_roleinRevokeRoleStmt.Check List
Tests
Code changes
Side effects
Related changes