Skip to content

executor, privilege: fix some two bug of RBAC (#11273)#11356

Merged
zz-jason merged 10 commits into
pingcap:release-3.0from
sre-bot:release-3.0-c00d8a95cfa1
Jul 30, 2019
Merged

executor, privilege: fix some two bug of RBAC (#11273)#11356
zz-jason merged 10 commits into
pingcap:release-3.0from
sre-bot:release-3.0-c00d8a95cfa1

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Jul 22, 2019

cherry-pick #11273 to release-3.0

@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Jul 22, 2019

/run-all-tests

@imtbkcat
Copy link
Copy Markdown

/run-all-tests

1 similar comment
@imtbkcat
Copy link
Copy Markdown

/run-all-tests

@imtbkcat
Copy link
Copy Markdown

/run-all-tests

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
@imtbkcat
Copy link
Copy Markdown

PTAL @tiancaiamao

@imtbkcat imtbkcat requested a review from jackysp July 29, 2019 03:08
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2019
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Jul 29, 2019

@sre-bot merge failed.

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2019
@zz-jason zz-jason merged commit 0d2ea4b into pingcap:release-3.0 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/privilege sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants