Skip to content

server/conn: log more detailed errors#11731

Merged
zz-jason merged 2 commits into
pingcap:masterfrom
lance6716:log-more-err
Aug 13, 2019
Merged

server/conn: log more detailed errors#11731
zz-jason merged 2 commits into
pingcap:masterfrom
lance6716:log-more-err

Conversation

@lance6716
Copy link
Copy Markdown
Contributor

@lance6716 lance6716 commented Aug 13, 2019

What problem does this PR solve?

Print more message to help investigate an bug: when executed some long-time-costing SQL and encountered timeout error, idleTime is relatively small to waitTimeout, e.g.

[2019/08/12 07:43:00.259 +00:00] [INFO] [conn.go:631] ["read packet timeout, close this connection"] [conn=12] [idle=2h11m42.271040483s] [waitTimeout=28800]

What is changed and how it works?

Print original error

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@lance6716 lance6716 added type/enhancement The issue or PR belongs to an enhancement. component/server errmsg labels Aug 13, 2019
@lance6716 lance6716 requested review from kennytm and lysu August 13, 2019 08:42
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 13, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2019

Codecov Report

Merging #11731 into master will decrease coverage by 0.1141%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##             master    #11731        +/-   ##
===============================================
- Coverage   81.5272%   81.413%   -0.1142%     
===============================================
  Files           432       432                
  Lines         93635     92979       -656     
===============================================
- Hits          76338     75697       -641     
+ Misses        11868     11866         -2     
+ Partials       5429      5416        -13

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 13, 2019

Codecov Report

Merging #11731 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11731   +/-   ##
===========================================
  Coverage   81.4327%   81.4327%           
===========================================
  Files           432        432           
  Lines         93250      93250           
===========================================
  Hits          75936      75936           
  Misses        11880      11880           
  Partials       5434       5434

Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu requested a review from tiancaiamao August 13, 2019 11:16
@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2019
@kennytm kennytm removed the errmsg label Aug 13, 2019
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Aug 13, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 13, 2019

/run-all-tests

@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 13, 2019

@lance6716 merge failed.

@zz-jason zz-jason merged commit 44292d0 into pingcap:master Aug 13, 2019
@lance6716 lance6716 deleted the log-more-err branch August 14, 2019 03:23
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.1 failed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 18, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-3.0 in PR #23400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants