Skip to content

server/conn: log more detailed errors (#11731)#23400

Merged
ti-chi-bot merged 1 commit into
pingcap:release-3.0from
ti-srebot:release-3.0-44292d01e9aa
Mar 19, 2021
Merged

server/conn: log more detailed errors (#11731)#23400
ti-chi-bot merged 1 commit into
pingcap:release-3.0from
ti-srebot:release-3.0-44292d01e9aa

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Mar 18, 2021

cherry-pick #11731 to release-3.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23400

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23400:release-3.0-44292d01e9aa

What problem does this PR solve?

Print more message to help investigate an bug: when executed some long-time-costing SQL and encountered timeout error, idleTime is relatively small to waitTimeout, e.g.

[2019/08/12 07:43:00.259 +00:00] [INFO] [conn.go:631] ["read packet timeout, close this connection"] [conn=12] [idle=2h11m42.271040483s] [waitTimeout=28800]

What is changed and how it works?

Print original error

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

  • No release note.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/server type/3.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Mar 18, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2021
@ti-srebot ti-srebot added this to the v3.0.21 milestone Mar 18, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@lance6716 you're already a collaborator in bot's repo.

@ti-srebot
Copy link
Copy Markdown
Contributor Author

@djshow832
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@github-actions github-actions Bot added the sig/sql-infra SIG: SQL Infra label Mar 18, 2021
@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 19, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 19, 2021
@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 19, 2021

/run-check_release_note

@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 19, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 38638f2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2021
@ti-chi-bot ti-chi-bot merged commit dbc5b4f into pingcap:release-3.0 Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/server sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/3.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants