ddl: fix add unique index on partitioned table (by RANGE COLUMNS) failed#11946
Merged
Conversation
Signed-off-by: Lonng <heng@lonng.org>
Contributor
Author
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11946 +/- ##
================================================
- Coverage 81.3468% 81.2134% -0.1334%
================================================
Files 443 443
Lines 95035 95015 -20
================================================
- Hits 77308 77165 -143
- Misses 12267 12356 +89
- Partials 5460 5494 +34 |
zimulala
reviewed
Aug 30, 2019
tiancaiamao
reviewed
Aug 30, 2019
Signed-off-by: Lonng <heng@lonng.org>
…fix-partition-range-col
Signed-off-by: Lonng <heng@lonng.org>
Contributor
|
LGTM |
crazycs520
approved these changes
Aug 30, 2019
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-3.0 failed |
Contributor
Author
|
Cherry-pick to release-3.0 after #11954 merged |
Contributor
|
/run-cherry-picker |
Contributor
|
cherry pick to release-3.0 in PR #11958 |
winkyao
pushed a commit
that referenced
this pull request
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
What is changed and how it works?
The
Exprfield inPartitionInfois not always be assigned a value (e.g:PARTITION BY RANGE COLUMNS(...)).This PR use columns in
PartitionInfodirectly if thePartitionInfo.Expris an empty string.Check List
Tests
Related changes
Release note