Skip to content

ddl: don't rely on expression.Column.ColName (#11255)#11954

Merged
sre-bot merged 2 commits into
pingcap:release-3.0from
winoros:pick
Aug 30, 2019
Merged

ddl: don't rely on expression.Column.ColName (#11255)#11954
sre-bot merged 2 commits into
pingcap:release-3.0from
winoros:pick

Conversation

@winoros
Copy link
Copy Markdown
Member

@winoros winoros commented Aug 30, 2019

What problem does this PR solve?

Cherry pick #11255 for @lonng 's future use.

Copy link
Copy Markdown
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 30, 2019

Sorry @lonng, you don't have permission to trigger auto merge event on this branch.

@zz-jason
Copy link
Copy Markdown
Member

/merge

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Aug 30, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Aug 30, 2019

/run-all-tests

@sre-bot sre-bot merged commit c706745 into pingcap:release-3.0 Aug 30, 2019
@winoros winoros deleted the pick branch September 5, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants