planner, executor: supports select statement with AS OF by nolouch · Pull Request #24613 · pingcap/tidb

nolouch · 2021-05-13T06:53:18Z

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Ref: #24557
Problem Summary:

Implement the syntax Select .... FROM xxx AS OF timestamp xxx with stale read.

What is changed and how it works?

the planner should visit the as of clause and extract the tso.

Check List

Tests

Unit test
Integration test

Release note

make select statements support stale read

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2021-05-17T06:58:45Z

PTAL @winoros @djshow832 @Yisaer @JmPotato @xhebox

xhebox

LGTM, expect that I am not sure if handles nested select stmt well. I doubt that it needs to be recursively called.

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2021-05-26T10:19:18Z

/run-all-tests

purelind · 2021-05-26T10:26:56Z

/run-unit-test

purelind · 2021-05-26T10:31:37Z

/run-sqllogic-test

ti-chi-bot · 2021-05-27T03:34:21Z

@JmPotato: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: nolouch <nolouch@gmail.com>

ti-chi-bot · 2021-05-27T11:11:34Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Yisaer
winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

winoros · 2021-05-27T11:11:43Z

/merge

ti-chi-bot · 2021-05-27T11:11:46Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: c7a8a96

ti-chi-bot · 2021-05-27T11:49:15Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-27T11:49:45Z

@nolouch: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-05-27T12:19:14Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

nolouch · 2021-05-27T13:02:38Z

/merge

ti-chi-bot · 2021-05-27T13:02:41Z

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ClSlaid · 2021-05-27T13:36:17Z

 		// to fix, Table 'test.ttt' doesn't exist
-		_ = Preprocess(s.ctx, stmt, s.is)
+		err = Preprocess(s.ctx, stmt, WithPreprocessorReturn(&PreprocessorReturn{InfoSchema: s.is}))
 		builder, _ := NewPlanBuilder(MockContext(), s.is, &hint.BlockHintProcessor{})


You forgot to check err here.
Try run make check before every commit.

Actually, errcheck will ignore test files.

planner, exector: supports select statement with AS OF

f9b49db

Signed-off-by: nolouch <nolouch@gmail.com>

ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2021

nolouch changed the title ~~planner, exector: supports select statement with AS OF~~ planner, executor: supports select statement with AS OF May 13, 2021

github-actions Bot added sig/execution SIG execution sig/planner SIG: Planner labels May 13, 2021

update proto

2ff63cf

Signed-off-by: nolouch <nolouch@gmail.com>

JmPotato reviewed May 13, 2021

View reviewed changes

Comment thread planner/core/logical_plan_builder.go Outdated

djshow832 reviewed May 13, 2021

View reviewed changes

Comment thread planner/core/logical_plan_builder.go Outdated

Comment thread planner/core/logical_plan_builder.go Outdated

nolouch added 2 commits May 14, 2021 00:41

fix

6afe3b9

Signed-off-by: nolouch <nolouch@gmail.com>

format

25f55ec

Signed-off-by: nolouch <nolouch@gmail.com>

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2021

nolouch added 2 commits May 17, 2021 05:34

add more tests

5fad63c

Signed-off-by: nolouch <nolouch@gmail.com>

Merge remote-tracking branch 'origin/master' into stale-select

c0a561a

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2021

nolouch marked this pull request as ready for review May 16, 2021 21:50

nolouch requested review from a team as code owners May 16, 2021 21:50

nolouch requested review from XuHuaiyu and removed request for a team May 16, 2021 21:50

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2021

nolouch added 3 commits May 17, 2021 05:52

clean up

b658219

Signed-off-by: nolouch <nolouch@gmail.com>

Merge remote-tracking branch 'origin/master' into stale-select

a06b1a3

update parser

0f99648

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch mentioned this pull request May 17, 2021

Support timestamp bounded read-only transactions on data replicas Tasklist #21094

Closed

45 tasks

winoros reviewed May 17, 2021

View reviewed changes

Comment thread planner/optimize.go Outdated

Comment thread planner/core/logical_plan_builder.go Outdated

Comment thread planner/core/logical_plan_builder.go Outdated

xhebox reviewed May 18, 2021

View reviewed changes

Comment thread executor/stale_txn_test.go Outdated

Comment thread executor/stale_txn_test.go Outdated

Comment thread executor/stale_txn_test.go Outdated

Comment thread planner/core/logical_plan_builder.go Outdated

Comment thread planner/core/logical_plan_builder.go Outdated

JmPotato reviewed May 18, 2021

View reviewed changes

Comment thread planner/optimize.go Outdated

address comments

c522744

Signed-off-by: nolouch <nolouch@gmail.com>

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2021

Merge branch 'master' into stale-select

55966f9

JmPotato approved these changes May 27, 2021

View reviewed changes

winoros reviewed May 27, 2021

View reviewed changes

Comment thread planner/optimize.go

Comment thread planner/core/errors.go

Comment thread planner/core/common_plans.go Outdated

Comment thread executor/prepared.go

nolouch added 2 commits May 27, 2021 18:52

address comment

0f56721

Signed-off-by: nolouch <nolouch@gmail.com>

Merge remote-tracking branch 'nolouch/stale-select' into stale-select

c7a8a96

winoros approved these changes May 27, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021

Merge branch 'master' into stale-select

df4850f

Merge branch 'master' into stale-select

6837ab5

ti-chi-bot merged commit f3557bb into pingcap:master May 27, 2021

nolouch deleted the stale-select branch May 27, 2021 13:12

ClSlaid reviewed May 27, 2021

View reviewed changes

ClSlaid mentioned this pull request May 27, 2021

planner/core/logical_plan_test.go: add error check #24942

Merged

xhebox mentioned this pull request Jun 3, 2021

*: infoschema compatibility with prepare #25080

Closed

Reminiscent mentioned this pull request Feb 9, 2022

planner: fix create binding panic when status.record-db-qp enable (#29519) #30373

Closed

12 tasks

Conversation

nolouch commented May 13, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nolouch commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xhebox left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nolouch commented May 26, 2021

Uh oh!

purelind commented May 26, 2021

Uh oh!

purelind commented May 26, 2021

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

winoros commented May 27, 2021

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

nolouch commented May 27, 2021

Uh oh!

ti-chi-bot commented May 27, 2021

Uh oh!

ClSlaid May 27, 2021

Choose a reason for hiding this comment

Uh oh!

JmPotato May 27, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nolouch commented May 17, 2021 •

edited

Loading