planner: fix create binding panic when status.record-db-qp enable (#29519)#30373
planner: fix create binding panic when status.record-db-qp enable (#29519)#30373ti-srebot wants to merge 1 commit into
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/run-all-tests |
|
@Reminiscent you're already a collaborator in bot's repo. |
|
The PR relies on other PRs, like #24613 and #25058. We decide to not merge this PR. If someone has requirements for this PR, they can ping me and reopen this PR. Besides, it can disable the config item status.record-db-qp to workaround. |
cherry-pick #29519 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30373After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #29503
Problem Summary:
nilforast.SelectStmt.From. When we create the empty table query, it will cause panic. E.g,select 1.tableInfoanddbInfotoast.StmtNodewhen we create the binding and the config record-db-qps enable.nilingetStmtDbLabelfunction for*ast.CreateBindingStmt, it will cause panic when the table is empty.What is changed and how it works?
nilforast.SelectStmt.From.tableInfoanddbInfotoast.StmtNodewhen we create the binding and the config record-db-qps enable.nilingetStmtDbLabelfunction for*ast.CreateBindingStmt.Check List
Tests
Side effects
Documentation
Release note