Skip to content

bindinfo,planner: report error when creating sql binding on temporary table#25058

Merged
ti-chi-bot merged 8 commits into
pingcap:masterfrom
tiancaiamao:sql-binding
Jun 15, 2021
Merged

bindinfo,planner: report error when creating sql binding on temporary table#25058
ti-chi-bot merged 8 commits into
pingcap:masterfrom
tiancaiamao:sql-binding

Conversation

@tiancaiamao
Copy link
Copy Markdown
Contributor

@tiancaiamao tiancaiamao commented Jun 2, 2021

What problem does this PR solve?

Return error when creating sql binding on temporary table.

Problem Summary:

What is changed and how it works?

What's Changed:

In preprocess, check the tables of create binding do not contains any temporary table.

How it Works:

Related changes

Check List

Tests

  • Unit test

Release note

  • No release note

@tiancaiamao tiancaiamao requested a review from a team as a code owner June 2, 2021 09:41
@tiancaiamao tiancaiamao requested review from XuHuaiyu and removed request for a team June 2, 2021 09:41
@tiancaiamao tiancaiamao mentioned this pull request Jun 2, 2021
Closed
89 tasks
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor Author

tiancaiamao commented Jun 2, 2021

/run-check_dev_2

@tiancaiamao tiancaiamao requested a review from djshow832 June 2, 2021 10:46
@github-actions github-actions Bot added the sig/planner SIG: Planner label Jun 2, 2021
djshow832
djshow832 reviewed Jun 3, 2021
View reviewed changes
Comment thread bindinfo/bind_test.go
@djshow832 djshow832 requested a review from eurekaka June 3, 2021 11:57
@djshow832 djshow832 added the sig/sql-infra SIG: SQL Infra label Jun 3, 2021
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 01:59
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@djshow832 djshow832 requested review from AilinKid and xhebox June 11, 2021 10:06
xhebox
xhebox reviewed Jun 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread planner/core/preprocess.go
Comment thread planner/core/preprocess.go
if err != nil {
// If the operation is order is: drop table -> drop binding
// The table doesn't exist, it is not an error.
if terror.ErrorEqual(err, infoschema.ErrTableNotExists) {
Copy link
Copy Markdown
Contributor

@xhebox xhebox Jun 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not this check silent all drop binding statements, including ones that trying to drop bindings for non-exsist or not-created tables? BTW, should add drop binding cases.

Copy link
Copy Markdown
Contributor Author

@tiancaiamao tiancaiamao Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not silent all drop binding statements error, it just silent the infoschema.ErrTableNotExists error.
The behaviour is the same, prior to this change, we do not check table existence, and now we check the table but ignore the ErrTableNotExists error

Check temporary table for drop binding is not necessary, because we forbid the create binding, then there are no temporary tables in drop binding ...

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@tiancaiamao
Copy link
Copy Markdown
Contributor Author

tiancaiamao commented Jun 15, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 87caedb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 15, 2021

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Copy Markdown
Contributor Author

tiancaiamao commented Jun 15, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit bd11917 into pingcap:master Jun 15, 2021
@tiancaiamao tiancaiamao deleted the sql-binding branch June 15, 2021 07:01
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Jun 23, 2021
@tiancaiamao
bindinfo,planner: report error when creating sql binding on temporary…
0839c8b 
… table (pingcap#25058)
@tiancaiamao tiancaiamao mentioned this pull request Jul 20, 2021
Closed
@Reminiscent Reminiscent mentioned this pull request Feb 9, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhebox xhebox xhebox approved these changes

@djshow832 djshow832 djshow832 approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees

No one assigned

Labels

sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiancaiamao @ti-chi-bot @xhebox @djshow832