Skip to content

ddl: add create table like check for temporary table#25082

Merged
ti-chi-bot merged 18 commits into
pingcap:masterfrom
Howie59:create-table-like-plus
Jun 11, 2021
Merged

ddl: add create table like check for temporary table#25082
ti-chi-bot merged 18 commits into
pingcap:masterfrom
Howie59:create-table-like-plus

Conversation

@Howie59
Copy link
Copy Markdown
Contributor

@Howie59 Howie59 commented Jun 3, 2021

What problem does this PR solve?

Issue Number: see #24168

What is changed and how it works?

Proposal: temporary table

What's Changed: add create tablel like check for temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59
add create table like test
ae952bb 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@Howie59 Howie59 requested a review from a team as a code owner June 3, 2021 05:44
@Howie59 Howie59 requested review from hanfei1991 and removed request for a team June 3, 2021 05:44
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2021
@github-actions github-actions Bot added the sig/sql-infra SIG: SQL Infra label Jun 3, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2021
@djshow832 djshow832 changed the title ddl: add create tablel like check for temporary table ddl: add create table like check for temporary table Jun 9, 2021
@djshow832 djshow832 requested review from djshow832 and tiancaiamao and removed request for hanfei1991 June 9, 2021 07:21
djshow832
djshow832 reviewed Jun 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check creating normal tables like temporary tables.

Comment thread ddl/serial_test.go
Comment thread ddl/serial_test.go
Comment thread planner/core/errors.go
@djshow832 djshow832 mentioned this pull request Jun 9, 2021
Closed
89 tasks
tiancaiamao
tiancaiamao reviewed Jun 10, 2021
View reviewed changes
Comment thread ddl/serial_test.go
Comment thread planner/core/preprocess.go Outdated
Comment thread ddl/serial_test.go
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 11, 2021
@djshow832
Copy link
Copy Markdown
Contributor

djshow832 commented Jun 11, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jun 11, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f6003ad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@Howie59
Copy link
Copy Markdown
Contributor Author

Howie59 commented Jun 11, 2021

/run-check_dev_2

@Howie59
Copy link
Copy Markdown
Contributor Author

Howie59 commented Jun 11, 2021

/run-common-test

@ti-chi-bot ti-chi-bot merged commit 5a16067 into pingcap:master Jun 11, 2021
@Howie59 Howie59 deleted the create-table-like-plus branch June 11, 2021 08:51
tiancaiamao pushed a commit to tiancaiamao/tidb that referenced this pull request Jun 23, 2021
@Howie59 @tiancaiamao
ddl: add create table like check for temporary table (pingcap#25082)
c60c954
@lcwangchao lcwangchao mentioned this pull request Aug 3, 2021
Merged
@Defined2014 Defined2014 mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees

No one assigned

Labels

sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Howie59 @ti-chi-bot @djshow832 @tiancaiamao