Skip to content

planner/core: fix duplicate enum items#26145

Merged
ti-chi-bot merged 7 commits into
pingcap:masterfrom
hanfei1991:hanfei/fix-enum-bug
Jul 12, 2021
Merged

planner/core: fix duplicate enum items#26145
ti-chi-bot merged 7 commits into
pingcap:masterfrom
hanfei1991:hanfei/fix-enum-bug

Conversation

@hanfei1991
Copy link
Copy Markdown
Member

@hanfei1991 hanfei1991 commented Jul 12, 2021

What problem does this PR solve?

Issue Number: close #25955

Problem Summary:
In this pr: #23203 , I support enum push down for only mpp exchanger. However, a month later this pr: #22686 is merged to support general enum type push-down. This leads to the elem lists are appended two times.

What is changed and how it works?

What's Changed:
Remove the #23203 code

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • planner/core: fix duplicate enum items

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2021
@hanfei1991
Copy link
Copy Markdown
Member Author

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e9beed9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2021
@hanfei1991
Copy link
Copy Markdown
Member Author

/run_check_dev_2

@hanfei1991
Copy link
Copy Markdown
Member Author

/merge

@ichn-hu ichn-hu mentioned this pull request Jul 12, 2021
@ti-chi-bot ti-chi-bot merged commit 00e1964 into pingcap:master Jul 12, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 13, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.0 in PR #26201

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 13, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Contributor

cherry pick to release-5.1 in PR #26202

@hanfei1991 hanfei1991 deleted the hanfei/fix-enum-bug branch July 13, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query failed by: ERROR 1105 (HY000): DB::Exception: Duplicate names in enum: 'a' = 27 and 'a' = 1

5 participants