Skip to content

planner/core: fix duplicate enum items (#26145)#26201

Closed
ti-srebot wants to merge 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-00e19642e55e
Closed

planner/core: fix duplicate enum items (#26145)#26201
ti-srebot wants to merge 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-00e19642e55e

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Jul 13, 2021

cherry-pick #26145 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26201

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26201:release-5.0-00e19642e55e

What problem does this PR solve?

Issue Number: close #25955

Problem Summary:
In this pr: #23203 , I support enum push down for only mpp exchanger. However, a month later this pr: #22686 is merged to support general enum type push-down. This leads to the elem lists are appended two times.

What is changed and how it works?

What's Changed:
Remove the #23203 code

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • planner/core: fix duplicate enum items

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner July 13, 2021 08:50
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team July 13, 2021 08:50
@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick labels Jul 13, 2021
@ti-srebot ti-srebot requested a review from rebelice July 13, 2021 08:51
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jul 13, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@hanfei1991 you're already a collaborator in bot's repo.

@hanfei1991 hanfei1991 closed this Jul 15, 2021
@hanfei1991
Copy link
Copy Markdown
Member

This pr has no need to merge to release 5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants