Skip to content

Makefile: add a lint for parser's keywords #54827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HuSharp wants to merge 1 commit into from
Closed

Makefile: add a lint for parser's keywords #54827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ check-setup:tools/bin/revive
precheck: fmt bazel_prepare

.PHONY: check
check: check-bazel-prepare parser_yacc check-parallel lint tidy testSuite errdoc license
check: check-bazel-prepare parser_yacc parser_genkeywords check-parallel lint tidy testSuite errdoc license

.PHONY: fmt
fmt:
Expand Down Expand Up @@ -129,7 +129,7 @@ test_part_1: checklist integrationtest
test_part_2: test_part_parser ut gogenerate br_unit_test dumpling_unit_test

.PHONY: test_part_parser
test_part_parser: parser_yacc test_part_parser_dev
test_part_parser: parser_yacc parser_genkeywords test_part_parser_dev

.PHONY: test_part_parser_dev
test_part_parser_dev: parser_fmt parser_unit_test
Expand All @@ -142,6 +142,10 @@ parser:
parser_yacc:
@cd pkg/parser && mv parser.go parser.go.committed && make parser && diff -u parser.go.committed parser.go && rm parser.go.committed

.PHONY: parser_genkeywords
parser_genkeywords:
@cd pkg/parser && mv keywords.go keywords.go.committed && make generate && diff -u keywords.go.committed keywords.go && rm keywords.go.committed

.PHONY: parser_fmt
parser_fmt:
@cd pkg/parser && make fmt
Expand Down
1 change: 1 addition & 0 deletions pkg/parser/keywords.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@ var Keywords = []KeywordsType{
{"VALIDATION", false, "unreserved"},
{"VALUE", false, "unreserved"},
{"VARIABLES", false, "unreserved"},
{"VECTOR", false, "unreserved"},
{"VIEW", false, "unreserved"},
{"VISIBLE", false, "unreserved"},
{"WAIT", false, "unreserved"},
Expand Down
2 changes: 1 addition & 1 deletion pkg/parser/keywords_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestKeywords(t *testing.T) {
}

func TestKeywordsLength(t *testing.T) {
require.Equal(t, 653, len(parser.Keywords))
require.Equal(t, 654, len(parser.Keywords))

reservedNr := 0
for _, kw := range parser.Keywords {
Expand Down