Skip to content

Makefile: add a lint for parser's keywords #54827

Closed
HuSharp wants to merge 1 commit into
pingcap:masterfrom
HuSharp:add_check_keywords_lint
Closed

Makefile: add a lint for parser's keywords #54827
HuSharp wants to merge 1 commit into
pingcap:masterfrom
HuSharp:add_check_keywords_lint

Conversation

@HuSharp
Copy link
Copy Markdown
Contributor

@HuSharp HuSharp commented Jul 23, 2024

What problem does this PR solve?

#54246 has not updated keywords, maybe we need a lint to check parser/keywords

Issue Number: Ref #54245

Problem Summary:

What changed and how does it work?

When meet error

$ make parser_genkeywords
make[1]: Entering directory '/data/nvme0n1/husharp/proj/tidb/pkg/parser'
go generate
make[1]: Leaving directory '/data/nvme0n1/husharp/proj/tidb/pkg/parser'
--- keywords.go.committed       2024-07-23 14:35:57.829246693 +0800
+++ keywords.go 2024-07-23 14:36:00.505309768 +0800
@@ -622,6 +622,7 @@
        {"VALIDATION", false, "unreserved"},
        {"VALUE", false, "unreserved"},
        {"VARIABLES", false, "unreserved"},
+       {"VECTOR", false, "unreserved"},
        {"VIEW", false, "unreserved"},
        {"VISIBLE", false, "unreserved"},
        {"WAIT", false, "unreserved"},
make: *** [Makefile:147: parser_genkeyword] Error 1

After fixing error

master* $ make parser_genkeywords
make[1]: Entering directory '/data/nvme0n1/husharp/proj/tidb/pkg/parser'
go generate
make[1]: Leaving directory '/data/nvme0n1/husharp/proj/tidb/pkg/parser'

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Jul 23, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jul 23, 2024
@tiprow
Copy link
Copy Markdown

tiprow Bot commented Jul 23, 2024

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the add_check_keywords_lint branch from ac327bb to f7c8a80 Compare July 23, 2024 06:47
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@HuSharp
Copy link
Copy Markdown
Contributor Author

HuSharp commented Jul 23, 2024

@breezewish @tangenta @glorv PTAL, thx!

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.7438%. Comparing base (cdd7c9e) to head (f7c8a80).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54827        +/-   ##
================================================
- Coverage   72.7769%   72.7438%   -0.0332%     
================================================
  Files          1557       1557                
  Lines        437912     437912                
================================================
- Hits         318699     318554       -145     
- Misses        99582      99663        +81     
- Partials      19631      19695        +64     
Flag Coverage Δ
unit 71.7502% <ø> (-0.0404%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 45.8002% <ø> (-0.0736%) ⬇️

@breezewish
Copy link
Copy Markdown
Member

Duplicate with #54371?

@HuSharp
Copy link
Copy Markdown
Contributor Author

HuSharp commented Jul 23, 2024

Duplicate with #54371?

Let's close this pr.

@HuSharp HuSharp closed this Jul 23, 2024
@HuSharp HuSharp deleted the add_check_keywords_lint branch July 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants