parser: Fix keywords & keywords not checked in CI#54371
Closed
breezewish wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
ti-chi-bot
Bot
added
do-not-merge/needs-tests-checked
release-note-none
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
ti-chi-bot
Bot
added
the
size/S
breezewish
changed the title
Signed-off-by: Wish <breezewish@outlook.com>
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54371 +/- ##
=================================================
- Coverage 72.8342% 56.0108% -16.8234%
=================================================
Files 1530 1652 +122
Lines 435975 609080 +173105
=================================================
+ Hits 317539 341151 +23612
- Misses 98801 244646 +145845
- Partials 19635 23283 +3648
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hawkingrei
approved these changes
Jul 1, 2024
Member
|
/retest |
dveeden
approved these changes
Jul 1, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dveeden, hawkingrei The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
dveeden
reviewed
Jul 1, 2024
Co-authored-by: Daniël van Eeden <github@myname.nl>
breezewish
removed
the
needs-cherry-pick-release-7.5
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
Signed-off-by: Wish <breezewish@outlook.com>
Member
Author
|
/retest |
3 tasks
HuSharp
reviewed
Jul 23, 2024
| test: fmt parser | ||
| sh test.sh | ||
|
|
||
| parser: parser.go hintparser.go |
Contributor
There was a problem hiding this comment.
Do we need to modify root/Makefile to check the lint?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #48801
Problem Summary:
What changed and how does it work?
In #48807 a new Make action is introduced. However this action is not invoked in CI, nor listed in TiDB Dev Guide, causes mistakes like #54246 (comment).
This PR:
make generatewhenmake parseris called, prevent future mistakes happen againCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.