resource_control: support unlimited keyword when setting the resource group

[HuSharp]

What problem does this PR solve?

Issue Number: close #54413

Problem Summary:

What changed and how does it work?

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+-----------+-------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
+---------+------------+----------+-----------+-------------+------------+
1 row in set (0.00 sec)

mysql> CREATE RESOURCE GROUP IF NOT EXISTS rg1   RU_PER_SEC = 100   BURSTABLE;
Query OK, 0 rows affected (0.07 sec)

mysql> CREATE RESOURCE GROUP IF NOT EXISTS rg2   RU_PER_SEC = unlimited   BURSTABLE;
Query OK, 0 rows affected (0.06 sec)

mysql> CREATE RESOURCE GROUP IF NOT EXISTS rg3   RU_PER_SEC = UNLIMITED   BURSTABLE;
Query OK, 0 rows affected (0.07 sec)

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+-----------+-------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
| rg1     | 100        | MEDIUM   | YES       | NULL        | NULL       |
| rg2     | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
| rg3     | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
+---------+------------+----------+-----------+-------------+------------+
4 rows in set (0.00 sec)

mysql> ALTER RESOURCE GROUP rg2 RU_PER_SEC = 200;
Query OK, 0 rows affected (0.05 sec)

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+-----------+-------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
| rg1     | 100        | MEDIUM   | YES       | NULL        | NULL       |
| rg2     | 200        | MEDIUM   | YES       | NULL        | NULL       |
| rg3     | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
+---------+------------+----------+-----------+-------------+------------+
4 rows in set (0.00 sec)

mysql> CREATE RESOURCE GROUP IF NOT EXISTS rg4   RU_PER_SEC = UNLIMITED   BURSTABLE=FALSE;
Query OK, 0 rows affected (0.06 sec)

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT | BACKGROUND |
+---------+------------+----------+-----------+-------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
| rg1     | 100        | MEDIUM   | YES       | NULL        | NULL       |
| rg2     | 200        | MEDIUM   | YES       | NULL        | NULL       |
| rg3     | UNLIMITED  | MEDIUM   | YES       | NULL        | NULL       |
| rg4     | UNLIMITED  | MEDIUM   | NO        | NULL        | NULL       |
+---------+------------+----------+-----------+-------------+------------+
5 rows in set (0.01 sec)

mysql> CREATE RESOURCE GROUP IF NOT EXISTS rg5   RU_PER_SEC = 'check'   BURSTABLE=FALSE;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 74 near "BURSTABLE=FALSE"The RU_PER_SEC value 'check' is not valid.

mysql> alter resource group rg1 RU_PER_SEC= unlimited QUERY_LIMIT=(EXEC_ELAPSED='15s' ACTION DRYRUN WATCH SIMILAR DURATION '10m0s')
    -> ;
Query OK, 0 rows affected (0.06 sec)

mysql> SELECT * FROM information_schema.resource_groups;
+---------+------------+----------+-----------+-------------------------------------------------------------------+------------+
| NAME    | RU_PER_SEC | PRIORITY | BURSTABLE | QUERY_LIMIT                                                       | BACKGROUND |
+---------+------------+----------+-----------+-------------------------------------------------------------------+------------+
| default | UNLIMITED  | MEDIUM   | YES       | NULL                                                              | NULL       |
| rg1     | UNLIMITED  | MEDIUM   | YES       | EXEC_ELAPSED='15s', ACTION=DRYRUN, WATCH=SIMILAR DURATION='10m0s' | NULL       |
| rg2     | 200        | MEDIUM   | YES       | NULL                                                              | NULL       |
| rg3     | UNLIMITED  | MEDIUM   | YES       | NULL                                                              | NULL       |
| rg4     | UNLIMITED  | MEDIUM   | NO        | NULL                                                              | NULL       |
+---------+------------+----------+-----------+-------------------------------------------------------------------+------------+
5 rows in set (0.01 sec)

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[HuSharp]

@nolouch @JmPotato PTAL, thx!

[tiprow]

Hi @HuSharp. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0466%. Comparing base (98b7858) to head (6b15ad8).
Report is 13 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54704        +/-   ##
================================================
- Coverage   74.7144%   74.0466%   -0.6678%     
================================================
  Files          1558       1561         +3     
  Lines        363836     441747     +77911     
================================================
+ Hits         271838     327099     +55261     
- Misses        72290      94328     +22038     
- Partials      19708      20320       +612     

Flag	Coverage Δ
integration	27.9100% <0.0000%> (?)
unit	71.6413% <100.0000%> (-1.9815%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-2.2428%)	⬇️
parser	∅ <ø> (∅)
br	51.7713% <ø> (+4.0933%)	⬆️

[HuSharp]

Someone who forgot to update, maybe we need a lint

[HuSharp]

added #54827

[glorv]

rest LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-26 02:22:43.018393195 +0000 UTC m=+1184585.009334657: ☑️ agreed by nolouch.
• 2024-07-26 06:26:22.471373479 +0000 UTC m=+1199204.462314949: ☑️ agreed by glorv.

[GMHDBJD]

LGTM

[ti-chi-bot]

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, glorv, GMHDBJD, nolouch, songrijie, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [GMHDBJD,glorv,tangenta]
• pkg/ddl/OWNERS [tangenta]
• pkg/domain/OWNERS [GMHDBJD,tangenta]
• pkg/meta/OWNERS [GMHDBJD,tangenta]
• pkg/parser/OWNERS [easonn7,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment