Skip to content

disjoinset: add generic impl#54917

Merged
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
winoros:disjointset
Jul 27, 2024
Merged

disjoinset: add generic impl#54917
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
winoros:disjointset

Conversation

@winoros
Copy link
Copy Markdown
Member

@winoros winoros commented Jul 25, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Add the generic implementation for disjoint set.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2024
@winoros winoros added skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/needs-linked-issue labels Jul 25, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6877%. Comparing base (8f98b4e) to head (d3d4fc9).
Report is 28 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54917        +/-   ##
================================================
+ Coverage   72.9336%   74.6877%   +1.7540%     
================================================
  Files          1558       1565         +7     
  Lines        438456     446689      +8233     
================================================
+ Hits         319782     333622     +13840     
+ Misses        99064      92672      -6392     
- Partials      19610      20395       +785     
Flag Coverage Δ
integration 49.5553% <12.5000%> (?)
unit 71.6300% <100.0000%> (-0.3205%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-0.0089%) ⬇️
parser ∅ <ø> (∅)
br 51.6143% <ø> (+5.7355%) ⬆️

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 25, 2024
Copy link
Copy Markdown
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset LGTM

Comment thread pkg/util/disjointset/set.go
Comment thread pkg/util/disjointset/set.go Outdated
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 26, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jul 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-25 15:05:16.8509347 +0000 UTC m=+1143938.841876171: ☑️ agreed by hawkingrei.
  • 2024-07-26 05:32:15.99117875 +0000 UTC m=+1195957.982120212: ☑️ agreed by AilinKid.

@winoros
Copy link
Copy Markdown
Member Author

winoros commented Jul 26, 2024

/retest

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jul 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 27, 2024
@winoros
Copy link
Copy Markdown
Member Author

winoros commented Jul 27, 2024

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 7cdf918 into pingcap:master Jul 27, 2024
@winoros winoros deleted the disjointset branch July 27, 2024 19:36
morgo added a commit to morgo/tidb that referenced this pull request Jul 28, 2024
* upstream/master: (93 commits)
  disjoinset: add generic impl (pingcap#54917)
  planner: derive index filters for mv index paths (pingcap#54877)
  br: cli refactor backup error handling logic (pingcap#54697)
  expression: fix infinity loop in `timestampadd` (pingcap#54916)
  planner: import more expand test. (pingcap#54962)
  planner: use code-gen to generate CloneForPlanCache method for some operators (pingcap#54957)
  test: fix flaky test TestFailSchemaSyncer (pingcap#54958)
  planner: move logical show into logicalop pkg. (pingcap#54928)
  privilege: Remove TestAbnormalMySQLTable (pingcap#54925)
  resource_control: support unlimited keyword when setting the resource group (pingcap#54704)
  ddl: fix a data race on localRowCntListener Written() (pingcap#54484)
  lightning: fix SET SESSION on connection pool (pingcap#54927)
  planner: move logical mem-table to logicalop pkg. (pingcap#54903)
  table: Add `CachedTableSupport` and `TemporaryTableSupport` for `MutateContext` (pingcap#54900)
  executor: fix index_hash_join hang when context canceled (pingcap#54855)
  statistics: add metrics for unneeded analyze table (pingcap#54822)
  *: refine pipelined dml benchmarks (pingcap#54844)
  ddl: assign table IDs for jobs submitted to queue (pingcap#54880)
  *: avoid using Tables field of model.DBInfo, use API instead (pingcap#52302)
  planner: remove useless check (pingcap#54907)
  ...
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants