test: fix flaky test TestFailSchemaSyncer

[D3Hunter]

What problem does this PR solve?

Issue Number: close #48758

Problem Summary:

What changed and how does it work?

if after schema validator restart, there is no reload within 200ms which is the ddllease before this pr, schemaValidator.latestSchemaExpire will expire, so later insert will fail with schema changed

tidb/pkg/domain/domain.go

Line 1076 in e0e8f89

do.SchemaValidator.Restart()

        	Error Trace:	/Users/xiedong/repos/tidb/pkg/testkit/testkit.go:157
        	            				/Users/xiedong/repos/tidb/pkg/testkit/testkit.go:150
        	            				/Users/xiedong/repos/tidb/pkg/ddl/tests/partition/db_partition_test.go:2674
        	Error:      	Received unexpected error:
        	            	[domain:8028]Information schema is changed during the execution of the statement(for example, table definition may be updated by other DDL ran in parallel). If you see this error often, try increasing `tidb_max_delta_schema_count`. [try again later]
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).checkSchemaValid
        	            		/Users/xiedong/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240626064248-4a72526f6c30/txnkv/transaction/2pc.go:1871
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).execute
        	            		/Users/xiedong/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240626064248-4a72526f6c30/txnkv/transaction/2pc.go:1694
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*KVTxn).Commit
        	            		/Users/xiedong/go/pkg/mod/github.com/tikv/client-go/v2@v2.0.8-0.20240626064248-4a72526f6c30/txnkv/transaction/txn.go:714
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).Commit
        	            		/Users/xiedong/repos/tidb/pkg/store/driver/txn/txn_driver.go:117
        	            	github.com/pingcap/tidb/pkg/session.(*LazyTxn).Commit
        	            		/Users/xiedong/repos/tidb/pkg/session/txn.go:449
        	            	github.com/pingcap/tidb/pkg/session.(*session).commitTxnWithTemporaryData
        	            		/Users/xiedong/repos/tidb/pkg/session/session.go:670
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommit
        	            		/Users/xiedong/repos/tidb/pkg/session/session.go:550
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommitWithRetry
        	            		/Users/xiedong/repos/tidb/pkg/session/session.go:792
        	            	github.com/pingcap/tidb/pkg/session.(*session).CommitTxn
        	            		/Users/xiedong/repos/tidb/pkg/session/session.go:922
        	            	github.com/pingcap/tidb/pkg/session.autoCommitAfterStmt
        	            		/Users/xiedong/repos/tidb/pkg/session/tidb.go:281
        	            	github.com/pingcap/tidb/pkg/session.finishStmt
        	            		/Users/xiedong/repos/tidb/pkg/session/tidb.go:243
        	            	github.com/pingcap/tidb/pkg/session.runStmt
        	            		/Users/xiedong/repos/tidb/pkg/session/session.go:2320
        	            	github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
        	            		/Users/xiedong/repos/tidb/pkg/session/session.go:2150
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).ExecWithContext
        	            		/Users/xiedong/repos/tidb/pkg/testkit/testkit.go:383
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExecWithContext
        	            		/Users/xiedong/repos/tidb/pkg/testkit/testkit.go:155
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExec
        	            		/Users/xiedong/repos/tidb/pkg/testkit/testkit.go:150
        	            	github.com/pingcap/tidb/pkg/ddl/tests/partition.TestPartitionErrorCode
        	            		/Users/xiedong/repos/tidb/pkg/ddl/tests/partition/db_partition_test.go:2674

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0479%. Comparing base (87d1657) to head (fb3b9dc).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54958        +/-   ##
================================================
+ Coverage   72.7208%   74.0479%   +1.3270%     
================================================
  Files          1560       1560                
  Lines        438485     438485                
================================================
+ Hits         318870     324689      +5819     
+ Misses        99974      93686      -6288     
- Partials      19641      20110       +469     

Flag	Coverage Δ
integration	28.0485% <ø> (?)
unit	71.6515% <ø> (-0.0599%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	52.5355% <ø> (+6.6245%)	⬆️

[Benjamin2037]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [Benjamin2037,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-26 09:41:32.303790691 +0000 UTC m=+1210914.294732162: ☑️ agreed by Benjamin2037.
• 2024-07-26 09:42:02.106959841 +0000 UTC m=+1210944.097901312: ☑️ agreed by tangenta.