*: avoid using Tables field of model.DBInfo, use API instead by tiancaiamao · Pull Request #52302 · pingcap/tidb

tiancaiamao · 2024-04-02T04:32:39Z

What problem does this PR solve?

Issue Number: close #52234

Problem Summary:

What changed and how does it work?

In infoschema V2, we don't know the full tables of a database.
So the Tables field of model.DBInfo in infoschema v2 is not set.

This is a kind of compatibility-breaker.
To make the switch more smooth, all the code should use infoschema.SchemaTableInfos API to get the tables of a database, this API works on both v1 and v2.

Check List

Tests

Unit test

refactor, the old test should all pass.

Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-04-02T04:32:56Z

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2024-04-02T05:00:45Z

Codecov Report

Attention: Patch coverage is 81.81818% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.9175%. Comparing base (628b7ed) to head (b7ff03e).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #52302         +/-   ##
=================================================
- Coverage   74.7370%   55.9175%   -18.8195%     
=================================================
  Files          1558       1680        +122     
  Lines        363833     610874     +247041     
=================================================
+ Hits         271918     341586      +69668     
- Misses        72136     246131     +173995     
- Partials      19779      23157       +3378

Flag	Coverage Δ
integration	`37.1692% <34.0425%> (?)`
unit	`71.6313% <81.8181%> (-1.8942%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <100.0000%> (-2.2428%)`	⬇️
parser	`∅ <ø> (∅)`
br	`61.9673% <ø> (+14.2570%)`	⬆️

GMHDBJD

LGTM

tiancaiamao · 2024-07-25T00:44:08Z

/retest

tiprow · 2024-07-25T00:44:30Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance6716 · 2024-07-25T07:45:25Z

/assign @fixdb

ti-chi-bot · 2024-07-25T08:18:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hi-rustin, lance6716, Leavrth, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,Leavrth,hi-rustin,lance6716,tangenta]
~~br/OWNERS~~ [Leavrth]
~~dumpling/OWNERS~~ [GMHDBJD,lance6716,tangenta]
~~pkg/ddl/OWNERS~~ [tangenta]
~~pkg/domain/OWNERS~~ [GMHDBJD,lance6716,tangenta]
~~pkg/infoschema/OWNERS~~ [GMHDBJD,tangenta]
~~pkg/parser/OWNERS~~ [tangenta]
~~pkg/planner/OWNERS~~ [hi-rustin]
~~pkg/statistics/OWNERS~~ [hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiancaiamao · 2024-07-25T08:33:45Z

/retest

tiprow · 2024-07-25T08:34:08Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2024-07-25T08:48:01Z

/retest

tiprow · 2024-07-25T08:48:24Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiancaiamao · 2024-07-25T09:27:35Z

/test pull-br-integration-test

tiprow · 2024-07-25T09:27:58Z

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* upstream/master: (93 commits) disjoinset: add generic impl (pingcap#54917) planner: derive index filters for mv index paths (pingcap#54877) br: cli refactor backup error handling logic (pingcap#54697) expression: fix infinity loop in `timestampadd` (pingcap#54916) planner: import more expand test. (pingcap#54962) planner: use code-gen to generate CloneForPlanCache method for some operators (pingcap#54957) test: fix flaky test TestFailSchemaSyncer (pingcap#54958) planner: move logical show into logicalop pkg. (pingcap#54928) privilege: Remove TestAbnormalMySQLTable (pingcap#54925) resource_control: support unlimited keyword when setting the resource group (pingcap#54704) ddl: fix a data race on localRowCntListener Written() (pingcap#54484) lightning: fix SET SESSION on connection pool (pingcap#54927) planner: move logical mem-table to logicalop pkg. (pingcap#54903) table: Add `CachedTableSupport` and `TemporaryTableSupport` for `MutateContext` (pingcap#54900) executor: fix index_hash_join hang when context canceled (pingcap#54855) statistics: add metrics for unneeded analyze table (pingcap#54822) *: refine pipelined dml benchmarks (pingcap#54844) ddl: assign table IDs for jobs submitted to queue (pingcap#54880) *: avoid using Tables field of model.DBInfo, use API instead (pingcap#52302) planner: remove useless check (pingcap#54907) ...

…#52302) close pingcap#52234

*: do not expose Tables field of model.DBInfo, use API instead

8401765

ti-chi-bot Bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2024

fix build of parser/model

bdc5779

ti-chi-bot Bot removed the do-not-merge/needs-triage-completed label Apr 2, 2024

fix build

5489b8a

ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2024

fix build of dumpling

e6f73ed

ti-chi-bot Bot added the component/dumpling This is related to Dumpling of TiDB. label Apr 2, 2024

tiancaiamao added 3 commits April 2, 2024 15:05

fix test ingest

bdf5261

fix test

739e917

Merge branch 'master' into dbinfo-tables

b39e43a

ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 2, 2024

tiancaiamao added 9 commits April 2, 2024 15:54

make fmt

3a3af26

fix build for pkg/infoschema

dab34d7

fix build

9595e5c

fix test build of restore

4d37cfc

fix build of planner/core

b31473b

fix br ci

5c08b24

make fmt

6d73408

Merge branch 'master' into dbinfo-tables

30e50a4

Merge branch 'master' into dbinfo-tables

d381709

ywqzzy self-requested a review April 9, 2024 07:03

ti-chi-bot Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024

Merge branch 'master' into dbinfo-tables

223a809

ti-chi-bot Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024

GMHDBJD approved these changes Jul 24, 2024

View reviewed changes

Merge branch 'master' into dbinfo-tables

75ffbf5

ti-chi-bot Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024

resolve conflict

59867b9

ti-chi-bot Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024

tangenta approved these changes Jul 25, 2024

View reviewed changes

Merge branch 'master' into dbinfo-tables

43591ba

ti-chi-bot Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 25, 2024

Leavrth approved these changes Jul 25, 2024

View reviewed changes

ti-chi-bot Bot assigned fixdb Jul 25, 2024

Merge branch 'master' into dbinfo-tables

b7ff03e

0xPoe approved these changes Jul 25, 2024

View reviewed changes

ti-chi-bot Bot added the approved label Jul 25, 2024

ti-chi-bot Bot merged commit 6c3e25e into pingcap:master Jul 25, 2024

tiancaiamao deleted the dbinfo-tables branch July 25, 2024 11:17

budney pushed a commit to budney/tidb that referenced this pull request May 18, 2025

*: avoid using Tables field of model.DBInfo, use API instead (pingcap…

ae1c246

…#52302) close pingcap#52234

Conversation

tiancaiamao commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Apr 2, 2024

Uh oh!

codecov Bot commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GMHDBJD left a comment

Choose a reason for hiding this comment

Uh oh!

tiancaiamao commented Jul 25, 2024

Uh oh!

tiprow Bot commented Jul 25, 2024

Uh oh!

lance6716 commented Jul 25, 2024

Uh oh!

ti-chi-bot Bot commented Jul 25, 2024

Uh oh!

tiancaiamao commented Jul 25, 2024

Uh oh!

tiprow Bot commented Jul 25, 2024

Uh oh!

tiancaiamao commented Jul 25, 2024

Uh oh!

tiprow Bot commented Jul 25, 2024

Uh oh!

tiancaiamao commented Jul 25, 2024

Uh oh!

tiprow Bot commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tiancaiamao commented Apr 2, 2024 •

edited

Loading

codecov Bot commented Apr 2, 2024 •

edited

Loading