config: Make deprecate-integer-display-length default to true | tidb-test=pr/2414 by dveeden · Pull Request #56529 · pingcap/tidb

dveeden · 2024-10-10T07:01:19Z

What problem does this PR solve?

Issue Number: close #56533 close #17682

Problem Summary:

Change the default for deprecate-integer-display-length.

This affects:

SHOW CREATE TABLE output
EXPLAIN output (mostly or only for cast(...) )
DESCRIBE <table>
Now a warning occurs if a display width is specified: Warning 1681 Integer display width is deprecated and will be removed in a future release.

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Integer display width display has been disabled by default.

ti-chi-bot · 2024-10-10T07:01:21Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2024-10-10T07:01:36Z

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dveeden · 2024-10-10T07:01:36Z

/ok-to-test

dveeden · 2024-10-10T07:01:45Z

/test all

codecov · 2024-10-10T07:22:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4854%. Comparing base (44f1c14) to head (3593f12).
Report is 1 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56529         +/-   ##
=================================================
- Coverage   73.3610%   56.4854%   -16.8757%     
=================================================
  Files          1634       1759        +125     
  Lines        452548     637478     +184930     
=================================================
+ Hits         331994     360082      +28088     
- Misses       100190     253427     +153237     
- Partials      20364      23969       +3605

Flag	Coverage Δ
integration	`36.6326% <ø> (?)`
unit	`72.4782% <ø> (-0.0169%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`52.7045% <ø> (+6.6846%)`	⬆️

dveeden · 2024-10-10T08:07:51Z

/test all

dveeden · 2024-10-10T08:18:42Z

/test all

dveeden · 2024-10-10T08:56:20Z

/retest

dveeden · 2024-10-10T09:31:49Z

/test mysql-test

tiprow · 2024-10-10T09:32:10Z

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dveeden · 2024-10-10T10:10:17Z

/test check_dev

ti-chi-bot · 2024-10-10T10:10:20Z

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test pull-unit-test-ddlv1

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

Details

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dveeden · 2024-10-10T10:10:28Z

/test check-dev

tiprow · 2024-10-10T10:10:38Z

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-10-10T10:10:49Z

@dveeden: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dveeden · 2024-10-10T11:15:17Z

/retest

dveeden · 2024-10-10T12:53:30Z

cc @benmeadowcroft @yudongusa

ti-chi-bot · 2024-10-10T15:09:53Z

[LGTM Timeline notifier]

Timeline:

2024-10-10 09:36:14.65650632 +0000 UTC m=+1125130.076719331: ☑️ agreed by Defined2014.
2024-10-10 15:09:52.428633404 +0000 UTC m=+1145147.848846415: ☑️ agreed by mjonss.

bb7133

LGTM

yudongusa

LGTM with document PR (pingcap/docs#19159)

ti-chi-bot · 2024-10-17T17:56:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, CbcWestwolf, Defined2014, mjonss, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CbcWestwolf,Defined2014,bb7133,mjonss]
~~pkg/config/OWNERS~~ [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dveeden · 2024-10-18T09:19:01Z

/retest

Defined2014 · 2024-10-22T03:34:20Z

Hi @dveeden, please fix the conflict with master branch. Thx

…_display_width

config: Make deprecate-integer-display-length default to true

0d5a9ef

ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 10, 2024

ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Oct 10, 2024

Update tests

af706eb

ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Oct 10, 2024

Update more tests

dd6fe2c

Update even more tests

d579677

dveeden changed the title ~~config: Make deprecate-integer-display-length default to true~~ config: Make deprecate-integer-display-length default to true | tidb-test=pr/2412 Oct 10, 2024

dveeden requested review from CbcWestwolf, Defined2014 and zimulala October 10, 2024 09:32

Defined2014 approved these changes Oct 10, 2024

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2024

dveeden changed the title ~~config: Make deprecate-integer-display-length default to true | tidb-test=pr/2412~~ config: Make deprecate-integer-display-length default to true | tidb-test=pr/2414 Oct 10, 2024

mjonss approved these changes Oct 10, 2024

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024

CbcWestwolf approved these changes Oct 11, 2024

View reviewed changes

bb7133 approved these changes Oct 11, 2024

View reviewed changes

dveeden mentioned this pull request Oct 17, 2024

Update docs for deprecate-integer-display-length=true pingcap/docs#19159

Merged

16 tasks

yudongusa approved these changes Oct 17, 2024

View reviewed changes

ti-chi-bot Bot added the approved label Oct 17, 2024

dveeden added 2 commits October 22, 2024 10:05

Merge remote-tracking branch 'upstream/master' into deprecate_integer…

59c072f

…_display_width

Update results for display width

3593f12

ti-chi-bot Bot merged commit 4275195 into pingcap:master Oct 22, 2024

This was referenced Oct 23, 2024

dm: import_v10x Test Case Fails in DM CI Due to Recent Changes in TiDB pingcap/tiflow#11680

Closed

ci(dm): Fix DM import_v10x Test Failure Due to TiDB int Type Display Change pingcap/tiflow#11681

Merged

dveeden mentioned this pull request Nov 13, 2024

Bulk update integer display width pingcap/docs#19393

Merged

16 tasks

qiancai mentioned this pull request Nov 18, 2024

Update docs for deprecate-integer-display-length=true pingcap/docs-cn#19114

Merged

16 tasks

xhebox mentioned this pull request Nov 29, 2024

Column precison lost in inforschema #57834

Closed

Conversation

dveeden commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot Bot commented Oct 10, 2024

Uh oh!

tiprow Bot commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

codecov Bot commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

tiprow Bot commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

ti-chi-bot Bot commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

tiprow Bot commented Oct 10, 2024

Uh oh!

tiprow Bot commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

dveeden commented Oct 10, 2024

Uh oh!

ti-chi-bot Bot commented Oct 10, 2024

[LGTM Timeline notifier]

Uh oh!

bb7133 left a comment

Choose a reason for hiding this comment

Uh oh!

yudongusa left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Oct 17, 2024

Uh oh!

dveeden commented Oct 18, 2024

Uh oh!

Defined2014 commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dveeden commented Oct 10, 2024 •

edited

Loading

codecov Bot commented Oct 10, 2024 •

edited

Loading