ci(dm): Fix DM import_v10x Test Failure Due to TiDB int Type Display Change#11681
Merged
ti-chi-bot[bot] merged 2 commits intoOct 23, 2024
Merged
Conversation
…ype display change
ti-chi-bot
Bot
added
release-note-none
Contributor
Author
|
cc @lance6716 |
ti-chi-bot
Bot
added
needs-1-more-lgtm
Co-authored-by: lance6716 <lance6716@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11681 +/- ##
================================================
+ Coverage 55.1512% 55.1937% +0.0424%
================================================
Files 1001 1001
Lines 136472 136472
================================================
+ Hits 75266 75324 +58
+ Misses 55694 55651 -43
+ Partials 5512 5497 -15 |
Contributor
Author
|
/retest |
Contributor
|
/check-issue-triage-complete |
asddongmen
approved these changes
Oct 23, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11680
This PR fixes the import_v10x test case in DM’s CI, which has been failing due to recent changes in TiDB. TiDB modified how the default int type is displayed when using the SHOW CREATE TABLE statement, causing the test to break. ref: pingcap/tidb#56529
What is changed and how it works?
I have updated the import_v10x test to accommodate the changes made in TiDB’s handling of int types in SHOW CREATE TABLE. This ensures compatibility with the latest version of TiDB and prevents the test from failing in future CI runs.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note