remove field RowBatchData and add field EncodeType#135
Merged
Conversation
XuHuaiyu
reviewed
Oct 8, 2019
Contributor
XuHuaiyu
left a comment
XuHuaiyu
left a comment
There was a problem hiding this comment.
Do we need to generate the .rs files?
breezewish
reviewed
Oct 8, 2019
| optional int64 warning_count = 6; | ||
| optional bytes row_batch_data = 7 [(gogoproto.customtype) = "github.com/pingcap/tipb/sharedbytes.SharedBytes", (gogoproto.nullable) = false]; | ||
| // It indicates the encode type of response. | ||
| optional EncodeType encode_type = 7 [(gogoproto.nullable) = false]; |
Member
There was a problem hiding this comment.
Optional change: Prefer to comment out repeated Row rows = 2; as well.
breezewish
approved these changes
Oct 8, 2019
XuHuaiyu
changed the title
This was referenced Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What have you changed?
Now the
SelectResponseuse two field to save Arrow/Default format data. But they are both bytes array and can use the same field. We can add fieldEncodeTypeinstead of fieldRowBatchData.So remove the field
RowBatchDataand add the flag fieldEncodeType.Related PR
TiDB: pingcap/tidb#12536