*: fix rolling_update_fail when using Arrow format.#145
Merged
Conversation
breezewish
approved these changes
Oct 29, 2019
XuHuaiyu
approved these changes
Oct 29, 2019
overvenus
reviewed
Oct 29, 2019
| repeated int64 output_counts = 5; | ||
| optional int64 warning_count = 6; | ||
| // It indicates the encode type of response. | ||
| optional EncodeType encode_type = 7 [(gogoproto.nullable) = false]; |
Member
There was a problem hiding this comment.
Better to reserve tag 7.
https://developers.google.com/protocol-buffers/docs/proto3#reserved
overvenus
pushed a commit
that referenced
this pull request
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In #135 , I change the photo and use the same number to indicate it. It will cause a compatibility problem, and rolling_update will fail.
In this pr, I use a new number to indicate the new field.
Related PR
pingcap/tidb#12899